Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update SDLActivity to 2.0.3 #392

Merged
merged 6 commits into from Jan 18, 2015
Merged

Android: Update SDLActivity to 2.0.3 #392

merged 6 commits into from Jan 18, 2015

Conversation

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Jan 17, 2015

RESOLVED: One bug left: After ending one game logcat is spammed with "W/dalvikvm(19986): Exception thrown (Ljava/lang/NullPointerException;) while throwing internal exception (Ljava/lang/NullPointerException;)" when closing the first game and then no other game starts anymore...
and no game starts anymore. I assume SDL doesnt terminate correctly.

RESOLVED:
On some devices (Samsung e.g.) the game is reddish. This is a SDL 2.0.3 bug.
https://bugzilla.libsdl.org/show_bug.cgi?id=2291
Workaround: Disable hardware overlays in the developer options of your device :(

@MarianoGnu

This comment has been minimized.

Why do you do this? both blocks do the same.

This comment has been minimized.

Copy link
Owner Author

@Ghabry Ghabry replied Jan 18, 2015

Oh that was to workaround a compile error because the classes weren't available in API10. But I figured out now how to compile with API12 and still support API10 (Android 2.3.3)

@Ghabry
Copy link
Member Author

@Ghabry Ghabry commented Jan 18, 2015

Android should work again now :)

Ready for merge

fdelapena added a commit that referenced this pull request Jan 18, 2015
Android: Update SDLActivity to 2.0.3
@fdelapena fdelapena merged commit 0151e56 into EasyRPG:master Jan 18, 2015
2 checks passed
2 checks passed
@fdelapena
continuous-integration/travis-ci The Travis CI build passed
Details
@fdelapena
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants