Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation addition (French) #412

Merged
merged 7 commits into from Feb 11, 2015
Merged

Localisation addition (French) #412

merged 7 commits into from Feb 11, 2015

Conversation

@BlisterB
Copy link
Member

@BlisterB BlisterB commented Feb 3, 2015

Android build : Add French Translation

Add french localisation
@Ghabry
Copy link
Member

@Ghabry Ghabry commented Feb 3, 2015

Will this "just work" when this file is available?

Don't be sad but nearly nobody will see the French translation. According to Google Play Stats (They are collecting a lot) the installs in French are less then 1%.

Country Percentage
Japan 55.44%
USA 9.27%
Korea 6.82%
Germany 5.50%
Mexico 2.73%
~80%

The Japanese extreme high percentage is because of a news on GigaZine.

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 3, 2015

Yep of course it works :p. Excuse me I should have provided an image :
http://img11.hostingpics.net/pics/510800Capturedcran20150203094759.png

Android selects the more appropriate ressources according to the name of the directory. In this case, if the system is fr-fr, fr, fr-be etc. Android will take the string in values-fr in priority, and the other in the default directory (if all the string are not in values-fr/string.xml).
If the system is in another langage, Android take the default directory (the one without option in its name).

Maybe the french community is not enormous but easyRPG interests them :). The last time a saw a thread in rpg-maker.fr, this app was not totally functional, this can be an explanation.

I am also moving some text from the code to the .xml, in Android we have to put string in string.xml to improve misspelling checking and localization process :).

@fdelapena
Copy link
Contributor

@fdelapena fdelapena commented Feb 3, 2015

Though game configuration settings could be eventually moved to a cross platform menu some day, I think having this on Android earlier is good as this is one of most popular (if not the first) port nowadays 👍. Translation strings could be reused later for the portable C++ app. I'll provide the values-es/string.xml translation on another pull request.

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 3, 2015

Okay, so I'll transfer all the ouput instructions on the code to string.xml. There are a lot of little ones remaining in the code :).

@@ -20,4 +20,5 @@
<string name="thai">Thai</string>
<string name="vietnamese">Vietnamese</string>
<string name="cancel">Cancel</string>
</resources>
<string name="no_game_found">No game found in $PATH</string>

This comment has been minimized.

@fdelapena

fdelapena Feb 3, 2015
Contributor

games has been replaced with game here. Could you push another commit to master adding the missing "s"?

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 3, 2015

Scuse, the no 's' is a french grammar rule :p.

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Feb 3, 2015

If you want you can also translate the other strings that are hardcoded in the code because I was lazy ;)

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 3, 2015

No problem, I will do that :).

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 8, 2015

String transfers and translation terminated :).

android:versionCode="1"
android:versionName="1.0"
android:versionCode="2533"
android:versionName="0.2.2.70"

This comment has been minimized.

@carstene1ns

carstene1ns Feb 8, 2015
Member

You accidentally overwrote a recent change here, please git pull/rebase before submitting changes to avoid this in the future.

This comment has been minimized.

@Ghabry

Ghabry Feb 8, 2015
Member

That wasnt an incorrect merge. This happened because he used the build script we use in Jenkins. This replaces the versionCode and versionName.

This comment has been minimized.

@BlisterB

BlisterB Feb 9, 2015
Author Member

Yep I forgot to ignore this file in the first commit, should I have to do anything ?

This comment has been minimized.

@Ghabry

Ghabry Feb 9, 2015
Member

Just make another commit with the lines changed to
android:versionCode="1"
android:versionName="1.0"

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 9, 2015

That's done :)

@fdelapena
Copy link
Contributor

@fdelapena fdelapena commented Feb 9, 2015

Thanks, almost done, you have committed a new file (.orig.xml) instead.

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Feb 9, 2015

Ahahah wtf what is this file, probably the github app, FIXED.

@fdelapena fdelapena added this to the 0.3 milestone Feb 11, 2015
fdelapena added a commit that referenced this pull request Feb 11, 2015
Localisation addition (French)
@fdelapena fdelapena merged commit 0959be4 into EasyRPG:master Feb 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci The Travis CI build passed
Details
@fdelapena
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants