Localisation addition (French) #412

Merged
merged 7 commits into from Feb 11, 2015

Projects

None yet

4 participants

@BlisterB
Member
BlisterB commented Feb 3, 2015

Android build : Add French Translation

@BlisterB BlisterB Localisation addition (French)
Add french localisation
ce873ce
@Ghabry
Member
Ghabry commented Feb 3, 2015

Will this "just work" when this file is available?

Don't be sad but nearly nobody will see the French translation. According to Google Play Stats (They are collecting a lot) the installs in French are less then 1%.

Country Percentage
Japan 55.44%
USA 9.27%
Korea 6.82%
Germany 5.50%
Mexico 2.73%
~80%

The Japanese extreme high percentage is because of a news on GigaZine.

@BlisterB
Member
BlisterB commented Feb 3, 2015

Yep of course it works :p. Excuse me I should have provided an image :
http://img11.hostingpics.net/pics/510800Capturedcran20150203094759.png

Android selects the more appropriate ressources according to the name of the directory. In this case, if the system is fr-fr, fr, fr-be etc. Android will take the string in values-fr in priority, and the other in the default directory (if all the string are not in values-fr/string.xml).
If the system is in another langage, Android take the default directory (the one without option in its name).

Maybe the french community is not enormous but easyRPG interests them :). The last time a saw a thread in rpg-maker.fr, this app was not totally functional, this can be an explanation.

I am also moving some text from the code to the .xml, in Android we have to put string in string.xml to improve misspelling checking and localization process :).

@fdelapena
Member

Though game configuration settings could be eventually moved to a cross platform menu some day, I think having this on Android earlier is good as this is one of most popular (if not the first) port nowadays 👍. Translation strings could be reused later for the portable C++ app. I'll provide the values-es/string.xml translation on another pull request.

@BlisterB
Member
BlisterB commented Feb 3, 2015

Okay, so I'll transfer all the ouput instructions on the code to string.xml. There are a lot of little ones remaining in the code :).

@fdelapena fdelapena commented on an outdated diff Feb 3, 2015
builds/android/res/values/strings.xml
@@ -20,4 +20,5 @@
<string name="thai">Thai</string>
<string name="vietnamese">Vietnamese</string>
<string name="cancel">Cancel</string>
-</resources>
+ <string name="no_game_found">No game found in $PATH</string>
@fdelapena
fdelapena Feb 3, 2015 Member

games has been replaced with game here. Could you push another commit to master adding the missing "s"?

@BlisterB BlisterB fix grammar rule
53860a4
@BlisterB
Member
BlisterB commented Feb 3, 2015

Scuse, the no 's' is a french grammar rule :p.

@Ghabry
Member
Ghabry commented Feb 3, 2015

If you want you can also translate the other strings that are hardcoded in the code because I was lazy ;)

@BlisterB
Member
BlisterB commented Feb 3, 2015

No problem, I will do that :).

BlisterB added some commits Feb 8, 2015
@BlisterB BlisterB outputs tranfers a40ce43
@BlisterB BlisterB Merge branch 'master' of https://github.com/BlisterBoy/Player.git
Conflicts:
	builds/android/res/values/strings.xml
8cc5a5f
@BlisterB BlisterB Output transfer terminated + French translation
b9b1900
@BlisterB
Member
BlisterB commented Feb 8, 2015

String transfers and translation terminated :).

@carstene1ns carstene1ns and 2 others commented on an outdated diff Feb 8, 2015
builds/android/AndroidManifest.xml
@@ -4,8 +4,8 @@
-->
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="org.easyrpg.player"
- android:versionCode="1"
- android:versionName="1.0"
+ android:versionCode="2533"
+ android:versionName="0.2.2.70"
@carstene1ns
carstene1ns Feb 8, 2015 Member

You accidentally overwrote a recent change here, please git pull/rebase before submitting changes to avoid this in the future.

@Ghabry
Ghabry Feb 8, 2015 Member

That wasnt an incorrect merge. This happened because he used the build script we use in Jenkins. This replaces the versionCode and versionName.

@BlisterB
BlisterB Feb 9, 2015 Member

Yep I forgot to ignore this file in the first commit, should I have to do anything ?

@Ghabry
Ghabry Feb 9, 2015 Member

Just make another commit with the lines changed to
android:versionCode="1"
android:versionName="1.0"

@BlisterB BlisterB Reinit Android version code and versionName
776c06e
@BlisterB
Member
BlisterB commented Feb 9, 2015

That's done :)

@fdelapena
Member

Thanks, almost done, you have committed a new file (.orig.xml) instead.

@BlisterB BlisterB Reinit versionCode and versionName
f82e8ad
@BlisterB
Member
BlisterB commented Feb 9, 2015

Ahahah wtf what is this file, probably the github app, FIXED.

@fdelapena fdelapena added the Android label Feb 10, 2015
@fdelapena fdelapena added this to the 0.3 milestone Feb 11, 2015
@fdelapena fdelapena merged commit 0959be4 into EasyRPG:master Feb 11, 2015

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment