Skip to content

/ Player

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten: Support command line, transitions and saves #425

Merged
merged 9 commits into from Feb 23, 2015
Merged

Emscripten: Support command line, transitions and saves #425

merged 9 commits into from Feb 23, 2015

Conversation

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Feb 22, 2015

Lets play a bit more ^_^
@Ghabry
Emscripten: Support passing of command line arguments
65a8ad2
@Ghabry Ghabry force-pushed the Ghabry:emscripten_playground branch from 4a101d1 to 65a8ad2 Feb 22, 2015
@Ghabry
Copy link
Member Author

@Ghabry Ghabry commented Feb 22, 2015

Some test cases:

Print help in console:
https://easy-rpg.org/jenkins/job/player-js-pr/ws/easyrpg-player.html?help

Start a test play directly with a new game on map 10 with position 1x1:
https://easy-rpg.org/jenkins/job/player-js-pr/ws/easyrpg-player.html?new-game&start-map-id=10&start-position=1%201&test-play
Ghabry added 2 commits Feb 22, 2015
@Ghabry
Transitions return to scene loop (= transitions in emscripten)
be9dcc7
@Ghabry
Fix crash when Inn is last event. Fix calling of Inn custom handler w…
1381888 
…hen night is free.
@Ghabry
Copy link
Member Author

@Ghabry Ghabry commented Feb 22, 2015

Test case (Inn):
https://easy-rpg.org/jenkins/job/player-js-pr/ws/easyrpg-player.html?new-game&test-play&start-map-id=35&start-position=5%2010

Test case (Transition):
https://easy-rpg.org/jenkins/job/player-js-pr/ws/easyrpg-player.html?new-game&test-play&start-map-id=29&start-position=0%208
@Ghabry Ghabry changed the title Emscripten: Support passing of command line arguments Emscripten: Support command line, transitions and saves Feb 22, 2015
@Ghabry Ghabry force-pushed the Ghabry:emscripten_playground branch 5 times, most recently from e8f1bd9 to 1cd2f7f Feb 22, 2015
@Ghabry
Emscripten: Make save persistent
2dbf491
@Ghabry Ghabry force-pushed the Ghabry:emscripten_playground branch from 1cd2f7f to 2dbf491 Feb 22, 2015
@Ghabry
emscripten-post.js: Replace tabs with spaces
1232ef8
@Ghabry
Copy link
Member Author

@Ghabry Ghabry commented Feb 23, 2015

Should be fine now...
Ghabry added 4 commits Feb 23, 2015
@Ghabry
Render FPS and global drawables on top of transitions
f36712a
@Ghabry
Fade to black on program close
be03b2b
@Ghabry
Emscripten: Don't render FPS on screen (always 0 FPS)
b93bfb8
@Ghabry
Emscripten: Show shutdown message
5dc90b4
fdelapena added a commit that referenced this pull request Feb 23, 2015
@fdelapena
Merge pull request #425 from Ghabry/emscripten_playground
eac2922 
Emscripten: Support command line, transitions and saves
@fdelapena fdelapena merged commit eac2922 into EasyRPG:master Feb 23, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fdelapena
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Ghabry @fdelapena