Add shadows to the airship. #441

Merged
merged 2 commits into from Mar 25, 2015

Projects

None yet

3 participants

@scurest
Contributor
scurest commented Mar 22, 2015

This adds shadows beneath the airship. I added a new sprite class that's visible when you're on the ship and put an instance in Spriteset_Map. The only annoying bit is updating it when the System graphic changes, which I did by having the interpreter notify the spriteset just like for chipset changes.

Are the only files I need to change after adding a file Makefile.am and the two vcxproj files? Did I do the vcxproj files right?


The colors are also wrong, though its hard to tell, especially over a real map. I'm blending the two shadows at 26% opacity, left one first. Here's the System graphic fdelapena posted in #436, drawn against a white background in RPG_RT, and again in EasyRPG with this branch. This also shows the effect of switching the order of the two sprites. The frame that shows the original System graphic in the corner is from RPG_RT.

compare

For comparison, this is using 25% opacity.

com25

The blending method is actually not separable: the blue in the system graphic has 0 for both its R and G components, but when blended to the map, the R and G components are disequal (189 vs 190). 26% was picked to get the R component correct.

(I'm not going to mess with this any more in this PR, this is just for documentation.)


The Z-value is also wrong, and has a #333-like effect. I'm not really sure how the Z values work; anyone know what it should be?

@scurest scurest Add shadows to the airship.
Done by adding a new sprite class and attaching an instance to
Spriteset_Map.
e5d8564
@fdelapena
Member

About the color value imprecision: RPG_RT is not using true color, seems to use RGB565, so don't worry about this.
About the z value, I don't know. There was some chat about current z values for all layers, but I don't remember where was, IRC or issue number.
Looks great anyways, despite of existing layer issues. Thanks!
About vcxproj: looks fine.

@Ghabry
Member
Ghabry commented Mar 24, 2015

Minor nitpick: Maybe call it Sprite_AirshipShadow instead of Sprite_Shadow to make the purpose a bit more obvious. Otherwise nothing to complain 👍.

Z-Value is a general problem fixing this is out-of-scope for this PR.

You altered the files correclty, PR builder passed.

@scurest
Contributor
scurest commented Mar 25, 2015

Agreed. Done. (I actually called it that in my first version, but I thought it was a little long :)

@fdelapena fdelapena merged commit 706a5ef into EasyRPG:master Mar 25, 2015

1 check passed

default Merged build finished.
Details
@scurest scurest deleted the scurest:airshipshadow branch Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment