Back button call menu in ButtonMapping Activities #511

Merged
merged 2 commits into from Jul 11, 2015

Projects

None yet

3 participants

@BlisterB
Member
BlisterB commented Jul 5, 2015

No description provided.

@BlisterB
Member
BlisterB commented Jul 5, 2015

I remembered that in Player Activity, back button ask a confirmation to quit the game.

Should I delete this behavior to call the menu too ?
Pro :

  • Less complicated GUI
  • Fix definitively #442
@fdelapena
Member

Because some recent devices don't have hardware menu buttons (only home and back buttons), I think any hardware involved menu button should be removed. Adding an action bar for this and stealing space in the game screen is ugly so this feature could be added to the back button instead.

A good device example without this button: HTC One.

@BlisterB
Member
BlisterB commented Jul 5, 2015

@fdelapena there is no hardware button involved in the android port :p . (My phone doesn't have such a button and I have no problem).
When we associate a menu to an activity, it creates an hamburger icon in the dock (software button) to reach the menu .

But I think I'll associate the menu to back button to the Player Activity, because back button is already associated to a pop-up box (asking for stopping the game).

@BlisterB
Member
BlisterB commented Jul 5, 2015

Done !

@Ghabry
Member
Ghabry commented Jul 5, 2015

Thanks for the fix. Just got back from a short weekend trip. Will check tomorrow :)

@fdelapena
Member

Tested here, back button works for adding/editing from the screen button layout editor with latest pull request generated .apk 👍.

@Ghabry
Member
Ghabry commented Jul 11, 2015

Sorry that this took so long, was without internet the last days.
Works perfect, thx.

@Ghabry Ghabry merged commit 5aeea88 into EasyRPG:master Jul 11, 2015

1 check passed

default Build finished.
Details
@Ghabry
Member
Ghabry commented Jul 11, 2015

One issue is still that the config function of the Game Browser is not obvious.
Similiar for long press to select region.

@fdelapena
Member

These UX issues have been reported at #512 some days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment