Hi guys, that was a big one. For the moment this is a functional update, UX improvements will become later. #575
Change ButtonMapping format
Android : Read button mapping file
Android : Clean ButtonMappingModel
Android : JSON serialisation and deserialisation
Android : new ButtonMappingActivity
Android : The Activity can retrieve the default button mapping
Android : Multiple InputLayout
Android : adapt the legacy browser
Android : PreferencesActivity : Clean + Documentation + UX improvement
Now the system indicate the default layout and you can directly edit a layout, you can now test it :).
Wow, that's so awesome. And works really excellent. Good job.
The only thing I miss is that the "Choose layout" dialog for a game does not indicate the current layout (radio buttons like "Change Region" dialog).
Thank you Ghabry ^^.
Yeah I agree, I was a bit lazy and was hopping no one would notice haha.
I'll do that, and a little surprise !
Android : Vibration support
EasyRPG now supports vibrations ^^.
Hmmm, this needs a JNI callback to vibrate when damage occurs ;)
The core have vibration support oO ?
If it's the case I'll maybe see how to add it to the android port (but I lack of time before my last school year begin :SS). For the moment the android port vibrate when we touch an on screen input. (We can enable/disable it in settings).
Talking about that. Android provide a Settings' system, it's the shitiest thing I've seen so far : no slider, we can't add normal view. It brings a lot of UX problem (useless clicks), I think I'll just make a custom activity.
Android : UX improvement (inputlayout managing in settings activity)
Android : support layout transparency
We can now modify the input layout transparency !
Android : UX improvements
The android port is now more beautiful, I'm not a designer (and supporting API 10 doesn't help) but I think it will be enough :p.
@Ghabry I'll use radio button to choose and input layout for a game, and I think it will be enough for this pull request ^^.
Don't worry, it's really nice.
Some more feedback:
Don't place a space between the last word and the ":".
The default setting for vibrations is questionable. I think vibrations for button presses are annoying, maybe others like it... We will see what the reviews say :D. But I don't think that the Cross should vibrate at all (even when On)
The button mapping edit scene is now broken for me, I only see black, no buttons are added/displayed (but ingame it works)
Android : setting for vibrating on sliding d pad + clean + bug correc…
Haaaaa english typo rules ^^".
For the vibration I was thinking the same thing :p. I hate when vibration is too present but some user like it (they don't need a visual feedback, some others play without the input layout). Now they have the choice !
I also fixed the button mapping bug.
Android : UX improvments
Android : indicate the game's layout
Now it indicates the game's layout.
Pfiuuu if you don't find a problem, I'm done with this pull request !
Reset button mapping clears the screen completly instead of reverting. In my opinion it should be the same as "Exit without Save" -> "Edit layout".
And a minor nitpick ;) (sorry): Can you move the config option "Manage Input layouts" to the top? Is the most important function in the settings.
Oh and I noticed that the "Choose layout" has "Cancel" and "OK" buttons. Change Region doesn't have this and auto closes. And the dialogs disagree on where to place the radio button (left / right), that's inconsistent ;)
For "Manage Input Layout" the problem is that it can take a long place (and hide other option I found usefull), and having a scrollbar in a scrollbar is not good for android UX. And honestly that doesn't really shock me :p.
You found a bug for the "reset mapping button" button oO. I don't know why it does that, it's supposed to display the standard 2000 layout. I'll fix that.
Thanks for the UX problem with Change Region, I didn't noticed. Android provide gui service reaaaally confusing.
My intention was to limit useless clicks, with this approach I don't like the presence of "Ok" button (I prefer directly validate the user choice). But you can't do that with radio buttons without doing an ugly design pattern x).
But well it's Android, I'll make the region button dialog look like the change layout (or Samsung's troll will come back).
The region change dialog was my first attempt to make a popup-dialog with Android, and I couldn't figure out the correct way to do this.
Not sure if auto closing is the best solution, afterwards I display a Toast to indicate what was really touched. So I think OK/Cancel is the better way. Is an extra click but more save that you get was you wanted (and not missed the option with your fat finger, especially on small displays).
I agree :).
Android : Fix bug in ButtonMapping system
About "A" and "B" for Enter and Cancel... what about Z and X for them?
Z and X oô ? This is awfull xpppp
I think a configuration for this is not worth it :D
A and B because I grown up with Nintendo :D
Yep, moreover A and B are respectively touch for Validation et Cancelation on RPG Maker (as a lot of other key). Maybe I didn't understand some thing.
Android : change the region change behavior
I did the region dialog thing, it's over !
Btw sorry guy but you probably will have to update translation in spanish and german. Hablo un poco español pero no lo suficiente :p.
You can delete the toast "region_modification_success" now. Before it was useful to indicate what was really touched because the dialog was auto closing.
Now it's superfluous.
Android : delete a useless message
I ask all translators to update there translations then slooowly :)
@BlisterBoy @fdelapena @myself