Android : fix #598

Merged
merged 14 commits into from Sep 30, 2015

Projects

None yet

3 participants

@BlisterB
Member

Fix for the problem @fdelapena found (i fixed another ui problem thinking it was the one he described).
The system should be bug free now

(NB : You can wait me to push the fix of setting UI before merging, maybe tomorrow)

BlisterB added some commits Sep 24, 2015
@BlisterB BlisterB Android : fix 0b1a33b
@BlisterB BlisterB Merge https://github.com/EasyRPG/Player 822d156
@BlisterB BlisterB Android : fix the input layout list in settings
17b7351
@BlisterB
Member

Seriously Android foack you. I did a super optimized pattern etc. BUT in android you can't add a list view in a scrollview without having UX problem (the list is too short, no option to set the size).

BUT it's done.

@Ghabry
Member
Ghabry commented Sep 25, 2015

Android...

Just a general note about git usage to avoid merge commits (from merging upstream/master):
You can use "git rebase upstream/master" to move your commits on the top of the upstream/master branch without generating extra commits.

In theory you can actually do this now, too. Just run the command and in the editor that opens (based on $EDITOR) remove the line "Merge https://...", then it should rebase on master with your merge commit deleted. (better backup your repo first) :D

@BlisterB
Member

Thanks for the explanation ! I confess I've stopped using the command line, I'm currently using the desktop app, do theses commits bother you ? If it's the case I'll restart to use the command line as you described :p.

@Ghabry
Member
Ghabry commented Sep 25, 2015

Do you use the github desktop app? This one is very limited.

It's just that many projects will not merge your PR when they see such avoidable commits. :D

@BlisterB
Member

Oh it's fine, some recent updates brings a lot of cool features :p.

@BlisterB
Member

Buttons are now resizable from Settings.
It's WIP : I've got to centre buttons when they are displayed, to keep the same position when they are resized. And I have also to adapt the default layout.

@BlisterB
Member

Uuuurgh, center buttons is good for ux but brings somes practical problems (with default input layout). Nevereding problems between those two faces of GUI programming x). Btw I think I'm closing to the good balance.

@BlisterB
Member

The virtual button's letter is now centered, and proportional to the button. I was failing in math for so long haha.

@BlisterB
Member

Hmmmm I think it's good !
I think it's enough for this PR, I don't have the time to implement sliders in button mapping activity for butons' size, but I think the slider in Settings Activity is enough !

@BlisterB
Member

I moved the button_mapping file to internal memory, this will be easier to deal with changing working directory

@BlisterB
Member

Sooooo, calling an external application to choose a directory isn't a good option (can't specify directory choosing, random result depending on API and installed applications). I'll use an extern library.
It's like choosing a starter pokémon, I choose you Turhan's library :
https://github.com/TurhanOz/ReactiveDirectoryChooser

I like his licence.

@Ghabry
Member
Ghabry commented Sep 29, 2015

Okay, so two solutions now: Document that the library is required for Android (and ask the user to get it on it's own). Or copy paste the part from "ReactiveDirectoryChooser/library/src/main" into your project, if it isn't too much stuff. @fdelapena feedback?

Nice license :D

Pls note that I won't be able to test Android stuff this week because I'm on a business trip and the hotel only offers free WiFi for one device. That one device is my Laptop and not my Tablet :D

@fdelapena
Member

Well, adding it as an external dependency would need to set up repos in Jenkins, document and update all involved READMEs and wiki, project files (is maven ever used?). There are not much .java files, copying the whole src looks good to me for now, at least for a faster deployment, though the lib looks maintained.

BTW, Android 6 is coming :trollface:.

@BlisterB
Member

I can't wait the Samsung's version hahaha.
Btw no need to wait Android 6 to be trolled : I found that this lib (and all the other one) use the android support library. I have no idea how to add it in the project...

@BlisterB
Member

Pfuuu those android problems are boring. I'll study the possibility to create my own directory chooser : it's just a dialog with a list of directory name. If there is no futur problem (like permission or whatever) it shouldn't be difficult.
Btw this is enough for this PR :) ! I didn't encounter any problem :).

(Have a nice trip Ghabry ;p).

@Ghabry
Member
Ghabry commented Sep 30, 2015

Thx and I can actually test it this evening... I can transfer it via USB :D

@BlisterB
Member

I did a directory chooser, that was very simple :B.
I'm finishing to implement the "changing directory" features. This won't be for this PR as it will necessitate some tests (system programming, yay).

@BlisterB BlisterB closed this Sep 30, 2015
@BlisterB BlisterB reopened this Sep 30, 2015
@Ghabry Ghabry merged commit 20fded2 into EasyRPG:master Sep 30, 2015

1 check passed

default Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment