Fix more emulation bugs #645

Merged
merged 8 commits into from Nov 5, 2015

Projects

None yet

2 participants

@Zegeri
Member
Zegeri commented Oct 31, 2015

Thanks to c5093e5, the game player will be blocked if the main interpreter executed a command in its last update. Any non-empty auto starting event will block completly the game player as long as it runs. This fixes #629, a bug where the player would trigger an event after a KeyInputProc and surely other unreported bugs.

e88b886 fixes one of the bugs reported by Mr.Faq2014 in the forums.

Up to now, in EasyRPG 0.3.2 after seeing the intro (one of the backgrounds doesn't scroll properly(...)

Zegeri added some commits Oct 29, 2015
@Zegeri Zegeri Fix character direction after page switch adf6c8b
@Zegeri Zegeri Apply tile substitution in GetTerrainTag (fixes #638) a2d83af
@Zegeri Zegeri Set need refresh flag to true after changing a game variable
Fixes #590
095f632
@Zegeri Zegeri Use correct screen flash level (fixes #644) 64fdf85
@Zegeri Zegeri Block game player if the main interpreter executed a command in the l…
…ast update

both in movement and while activating action-triggered events
c5093e5
@Zegeri Zegeri Fix ShowBattleAnim and PanScreen right after a teleport
The flag 'active' has been replaced with two flags 'waiting_pan_screen'
and 'waiting_battle_anim' that are used only in their related commands.

Notice that 'move_route_waiting' is never set to true.
ProceedWithMovement hasn't been using this flag for quite a while now.
e88b886
@Ghabry
Member
Ghabry commented Oct 31, 2015

The last commit (active to anim and pan) is a hot candidate for fixing the visual bugs in battle of Sacred tears. I figured out weeks ago that the battle pans the screen which was not executed in player due to the active flag (but i couldn't fix it)

@Ghabry Ghabry added this to the 0.4 milestone Oct 31, 2015
Zegeri added some commits Nov 1, 2015
@Zegeri Zegeri Add missing comments in interpreter commands 0b76608
@Zegeri Zegeri Fix issues with parallel common events after being deactivated and
during teleportations
103fe30
@Zegeri
Member
Zegeri commented Nov 5, 2015

103fe30 fixes #578 again.

@Ghabry
Member
Ghabry commented Nov 5, 2015

Looks good for me, is it ready?

@Zegeri
Member
Zegeri commented Nov 5, 2015

It's ready.

@Ghabry Ghabry merged commit d23b8df into EasyRPG:master Nov 5, 2015

6 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
Linux (static) Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details
@Ghabry
Member
Ghabry commented Nov 7, 2015

That main_flag fix combined with your Panscreen change fixed the battle system of Sacred Tears: TRUE (the battle pans 2 tiles to the right, was not executed before). Just wanted to debug it but was already resolved :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment