New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify C++11 for CMake #737

Merged
merged 1 commit into from Jan 24, 2016

Conversation

Projects
None yet
3 participants
@scurest
Contributor

scurest commented Jan 24, 2016

Building with CMake is broken, because C++11 is used, but CXX_STANDARD isn't specified.

This does bump the minimum required version of CMake though.

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Jan 24, 2016

cough #320
Maybe we can get it through this time... 😀

@scurest

This comment has been minimized.

Contributor

scurest commented Jan 24, 2016

Oh, actually I do remember that! :)

But that was before. for example, b0b7152. Requring C++11 to build the codebase seems to constitute a de facto C++11 policy.

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Jan 24, 2016

yes, i am okay with it, but maybe we can go without requiring a newer cmake version and gcc>=4.7?
No idea what is used now on debian, but this approach still works with 2.8: #320 (comment)

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Jan 24, 2016

well, whatever, they can use autotools if they want, lol

@fdelapena

This comment has been minimized.

Contributor

fdelapena commented Jan 24, 2016

Yeah, C++11 code started landing, so the old policy is over. Even with pretty recent cmake requirement looks good to me, distributions with old package versions still may use autotools when needed IMO, as points Carsten.

fdelapena added a commit that referenced this pull request Jan 24, 2016

@fdelapena fdelapena merged commit 80e4327 into EasyRPG:master Jan 24, 2016

6 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
Linux (static) Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details

@scurest scurest deleted the scurest:c++11-standard branch Jan 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment