New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some nasty bugs #768

Merged
merged 14 commits into from Feb 15, 2016

Conversation

Projects
None yet
2 participants
@Zegeri
Member

Zegeri commented Feb 12, 2016

0ff788e and 7fb61a7 fix the issue reported by omochi-man by email.

Zegeri added some commits Feb 9, 2016

Do not create all common events again at loading
Also: remove unused battle variable in common event class
Fix mistake in Game_Player::IsBlockedByMoveRoute
and remove unused Game_Interpreter::EndMoveRoute
Replicate the weird behavior of move routes and triggers
While on a move route, the player shall not trigger touch/collision
events. When the move route ends (by reaching the last command or by
using Halt All Movement), it'll check the touch/collision triggers if
the last command executed was a Move command.

Fixes #687
Make more accurate cycle self movement and MoveTowardsPlayer
Also fix out-of-bounds access when using savegames from before this pull
request.
Avoid update of the game map in two frames during teleports
The frame when FinishTeleportPlayer is called already updates the game
map (only the parallel events). In the next frame, when the Show
Transition starts, it shouldn't update the map events.
Tweak a bit the event direction after page switch
so that it doesn't ever change movement direction while moving.
Do not reset middle pattern when SetGraphic doesn't change sprite
Also: Fix corner case of non-blocking move routes and touch/collision
triggers
@Zegeri

This comment has been minimized.

Show comment
Hide comment
@Zegeri

Zegeri Feb 15, 2016

Member

This last commit fixes the nasty bug in Nobisen ACE (のび太戦記ACE) reported in an email from pee kiyo.

This is ready for review.

Member

Zegeri commented Feb 15, 2016

This last commit fixes the nasty bug in Nobisen ACE (のび太戦記ACE) reported in an email from pee kiyo.

This is ready for review.

Ghabry added a commit that referenced this pull request Feb 15, 2016

@Ghabry Ghabry merged commit c611c89 into EasyRPG:master Feb 15, 2016

5 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details

@Ghabry Ghabry added this to the 0.4.1 milestone Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment