New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle and crash fixes and Async #770

Merged
merged 17 commits into from Feb 19, 2016

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Feb 15, 2016

Fixes battle hangs and that some skills never hit and some OOB array access and other crashes.

@Ghabry Ghabry added this to the 0.4.1 milestone Feb 15, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 16, 2016

Member

Jenkins: Test this please 💗

Member

Ghabry commented Feb 16, 2016

Jenkins: Test this please 💗

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 16, 2016

Member

This one is ready. I had planned to fix ChangeClass completely but this costs more freetime than I can alloc currently.

Member

Ghabry commented Feb 16, 2016

This one is ready. I had planned to fix ChangeClass completely but this costs more freetime than I can alloc currently.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Feb 16, 2016

Is this to deal with broken savegames created by Player or can this happen with RPG_RT, too?

carstene1ns commented on 78a4486 Feb 16, 2016

Is this to deal with broken savegames created by Player or can this happen with RPG_RT, too?

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 16, 2016

Owner

For broken Player savegames

Owner

Ghabry replied Feb 16, 2016

For broken Player savegames

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Feb 16, 2016

Well, this particular range check does not hurt, but generally it would be good to have some policy to identify backward compatible quirks so they get not removed by refactoring OR should be removed by refactoring in the future.

carstene1ns replied Feb 16, 2016

Well, this particular range check does not hurt, but generally it would be good to have some policy to identify backward compatible quirks so they get not removed by refactoring OR should be removed by refactoring in the future.

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 16, 2016

Owner

I will add a comment

Owner

Ghabry replied Feb 16, 2016

I will add a comment

@Ghabry Ghabry changed the title from Battle and crash fixes to Battle and crash fixes and Async Feb 19, 2016

fdelapena added a commit that referenced this pull request Feb 19, 2016

Merge pull request #770 from Ghabry/development
Battle and crash fixes and Async

@fdelapena fdelapena merged commit 9f832f2 into EasyRPG:master Feb 19, 2016

5 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment