Battle and crash fixes and Async #770

Merged
merged 17 commits into from Feb 19, 2016

Projects

None yet

3 participants

@Ghabry
Member
Ghabry commented Feb 15, 2016

Fixes battle hangs and that some skills never hit and some OOB array access and other crashes.

@Ghabry Ghabry added this to the 0.4.1 milestone Feb 15, 2016
@Ghabry
Member
Ghabry commented Feb 16, 2016

Jenkins: Test this please πŸ’—

Ghabry added some commits Feb 2, 2016
@Ghabry Ghabry Fix of-by-one error in Scene_ActorTarget which resulted in an incorre…
…ct SP calculation
6164919
@Ghabry Ghabry Battle: Remove unneeded includes ee4accd
@Ghabry Ghabry Battle RPG2k3: Fix self destruct deadlock 4631e3c
@Ghabry Ghabry Battle: Even 0 Base Damage can deal damage. Fixes #766 e6630ec
@Ghabry Ghabry Prevent crash if --project-path points to an invalid location 92a7c20
@Ghabry Ghabry Fix a crash (OOB read) in savegames that don't have data.changed_clas…
…s set correctly
78a4486
@Ghabry Ghabry MSVC: Add harfbuzz lib and deps 6b4e93c
@Ghabry Ghabry Performance optimization: Don't update ChipSet if it stayed the same f13a38d
@Ghabry Ghabry Only skip an event command when the save was caused by the "OpenSaveM…
…enu" event. Otherwise this can have side effects like skipping flow statements. Related: #757
1dbad28
@Ghabry
Member
Ghabry commented Feb 16, 2016

This one is ready. I had planned to fix ChangeClass completely but this costs more freetime than I can alloc currently.

@carstene1ns

Is this to deal with broken savegames created by Player or can this happen with RPG_RT, too?

Owner

For broken Player savegames

Well, this particular range check does not hurt, but generally it would be good to have some policy to identify backward compatible quirks so they get not removed by refactoring OR should be removed by refactoring in the future.

Owner

I will add a comment

Ghabry added some commits Feb 16, 2016
@Ghabry Ghabry Explain data.class_id check
930e87c
@Ghabry Ghabry Fix out of bounds array access in CancelMoveRoute 3d2f22e
@Ghabry Ghabry AsyncHandler: Prevent race conditions via shared_ptr
e5a7975
@Ghabry Ghabry Emscripten: MoveCommand sound effects were not passed through the Gam…
…e_System and never fetched. Fixes #509
c4adb8c
@Ghabry Ghabry Async_Handler: Improve Bind documentation. Rename FileRequestPending …
…to FileRequestBinding
0f27f89
@Ghabry Ghabry Async: Cancel music after BgmStop. Play each pending sound effect once. 2cee41a
@Ghabry Ghabry Async: Fix Face/Chara rendering issues in Menu, Shop and message
0794df3
@Ghabry Ghabry changed the title from Battle and crash fixes to Battle and crash fixes and Async Feb 19, 2016
@Ghabry Ghabry Delay load vehicles (when they appear first time on a map)
7edb5d0
@fdelapena fdelapena merged commit 9f832f2 into EasyRPG:master Feb 19, 2016

5 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment