Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of platform subfolder #772

Merged
merged 4 commits into from Feb 21, 2016
Merged

Get rid of platform subfolder #772

merged 4 commits into from Feb 21, 2016

Conversation

fdelapena
Copy link
Contributor

There are already platform specific files in the src folder, e.g. input_buttons_*.
The purpose of this pull request is normalize these cases and use proper preprocessor guards instead of using dummy files just for including them.

This PR has nothing to do with a proper subfolder redesign, if considered in the future to make source code navigation cleaner could be OK, this should not be considered as a step back.

audio_.reset(new SdlAudio());
#elif defined(HAVE_OPENAL)
#elif HAVE_OPENAL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checks are not the same. You check if HAVE_SDL_MIXER is defined at all (may be set 0 => disabled or even some random string "foobar") and then check if HAVE_OPENAL is defined and set to true (i.e. 1).
I do not consider the way it was done before really better, but it should be consistent.

@carstene1ns
Copy link
Member

The good thing about this pull request is that the build systems like autotools now detect if things in the formerly hidden (i.e. not timestamped) platform/* files changed 👍.

Ghabry added a commit that referenced this pull request Feb 21, 2016
Get rid of platform subfolder
@Ghabry Ghabry merged commit 4a25f54 into EasyRPG:master Feb 21, 2016
@fdelapena fdelapena deleted the platform branch February 21, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants