New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of platform subfolder #772

Merged
merged 4 commits into from Feb 21, 2016

Conversation

Projects
None yet
3 participants
@fdelapena
Contributor

fdelapena commented Feb 21, 2016

There are already platform specific files in the src folder, e.g. input_buttons_*.
The purpose of this pull request is normalize these cases and use proper preprocessor guards instead of using dummy files just for including them.

This PR has nothing to do with a proper subfolder redesign, if considered in the future to make source code navigation cleaner could be OK, this should not be considered as a step back.

Show outdated Hide outdated src/sdl_ui.cpp
# define NOMINMAX
# endif
# include <windows.h>
# include "SDL_syswm.h"

This comment has been minimized.

@carstene1ns

carstene1ns Feb 21, 2016

Member

We really need a tab vs. spaces policy somehow.

@carstene1ns

carstene1ns Feb 21, 2016

Member

We really need a tab vs. spaces policy somehow.

This comment has been minimized.

@fdelapena

fdelapena Feb 21, 2016

Contributor

Some years ago we changed these to the way I did because of http://stackoverflow.com/a/789156/1244033

@fdelapena

fdelapena Feb 21, 2016

Contributor

Some years ago we changed these to the way I did because of http://stackoverflow.com/a/789156/1244033

@@ -605,3 +607,5 @@ void ALAudio::SE_Stop() {
}
se_src_.clear();
}
#endif

This comment has been minimized.

@carstene1ns

carstene1ns Feb 21, 2016

Member

Also a policy to include or not include comments about closing preprocessor conditionals // HAVE_OPENAL

@carstene1ns

carstene1ns Feb 21, 2016

Member

Also a policy to include or not include comments about closing preprocessor conditionals // HAVE_OPENAL

@@ -1211,4 +1218,4 @@ void GekkoResetCallback() {
}
#endif
#endif
#endif // USE_SDL

This comment has been minimized.

@carstene1ns

carstene1ns Feb 21, 2016

Member

(added here for example)

@carstene1ns

carstene1ns Feb 21, 2016

Member

(added here for example)

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Feb 21, 2016

Member

The good thing about this pull request is that the build systems like autotools now detect if things in the formerly hidden (i.e. not timestamped) platform/* files changed 👍.

Member

carstene1ns commented Feb 21, 2016

The good thing about this pull request is that the build systems like autotools now detect if things in the formerly hidden (i.e. not timestamped) platform/* files changed 👍.

Ghabry added a commit that referenced this pull request Feb 21, 2016

Merge pull request #772 from fdelapena/platform
Get rid of platform subfolder

@Ghabry Ghabry merged commit 4a25f54 into EasyRPG:master Feb 21, 2016

4 of 5 checks passed

web Build finished. No test results found.
Details
Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details

@fdelapena fdelapena deleted the fdelapena:platform branch Feb 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment