Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash fixes + ATB #796

Merged
merged 6 commits into from Mar 6, 2016

Conversation

Projects
None yet
2 participants
@Ghabry
Copy link
Member

Ghabry commented Mar 5, 2016

Fixes some crashes (opening the menu in some cases, reported via Android bug mails...).

Adds saving/loading the ATB flag.

End Game returns to game browser now and music fade out works for ADPCM files (SDL .)

Ghabry added some commits Mar 1, 2016

CommandExitGame returns now to the Game browser (if available). Fix #791


Also add BGM fadeout to GameBrowser to get rid of background music and remove BGS fade everywhere because it is not used (only indirectly through BGM_Face by the broken SDL_audio).
Fix handling of BGS_Pause, BGS_Resume and BGS_Stop functions for the …
…case that a ADPCM WAV file is loaded which triggers a SDL audio bug that is worked around in our code (and bgm as a nullptr).

@Ghabry Ghabry force-pushed the Ghabry:development branch from c0498da to 506c31a Mar 5, 2016

fdelapena added a commit that referenced this pull request Mar 6, 2016

@fdelapena fdelapena merged commit 1130586 into EasyRPG:master Mar 6, 2016

5 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.