New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the possibility to disable sounds in app settings #835

Merged
merged 3 commits into from Mar 20, 2016

Conversation

Projects
None yet
3 participants
@BachirAmiri

Yosh !

I just pushed the option in setting to disable sounds , by using the "--disable-audio" that was mentioned in the #575 issue. I hope that fits with what was asked.

Oui-Oui baguette. Cf BlisterB haha

Show outdated Hide outdated builds/android/res/values/strings.xml
@@ -80,6 +80,7 @@ Please tell us in detail what went wrong.\n
<string name="add_game_folder">Add a game folder</string>
<string name="enable_vibration">Enable vibrations</string>
<string name="vibrate_when_sliding_direction">Vibrate when sliding to another direction</string>
<string name="disable_sounds">Disable sounds</string>

This comment has been minimized.

@Ghabry

Ghabry Mar 20, 2016

Member

Because it's a check box it should be checked by default and have the label "Enable audio" (Disabling by checking is confusing)

@Ghabry

Ghabry Mar 20, 2016

Member

Because it's a check box it should be checked by default and have the label "Enable audio" (Disabling by checking is confusing)

This comment has been minimized.

@BachirAmiri

BachirAmiri Mar 20, 2016

Yeah i had a another perspective , ill change that no problem

@BachirAmiri

BachirAmiri Mar 20, 2016

Yeah i had a another perspective , ill change that no problem

Show outdated Hide outdated builds/android/src/org/easyrpg/player/SettingsActivity.java
import android.widget.Toast;
import android.media.AudioManager;

This comment has been minimized.

@Ghabry

Ghabry Mar 20, 2016

Member

Why are you importing these media libs?

@Ghabry

Ghabry Mar 20, 2016

Member

Why are you importing these media libs?

This comment has been minimized.

@BachirAmiri

BachirAmiri Mar 20, 2016

Just forgot to delete this from an older test. i will take it off.

@BachirAmiri

BachirAmiri Mar 20, 2016

Just forgot to delete this from an older test. i will take it off.

Show outdated Hide outdated builds/android/src/org/easyrpg/player/SettingsActivity.java
}
editor.commit();
}

This comment has been minimized.

@Ghabry

Ghabry Mar 20, 2016

Member

Just for Information: Because the if-condition is a bool this can be simplified to a one-liner:

editor.putBoolean(getString(R.string.disable_sounds), s.isChecked());
@Ghabry

Ghabry Mar 20, 2016

Member

Just for Information: Because the if-condition is a bool this can be simplified to a one-liner:

editor.putBoolean(getString(R.string.disable_sounds), s.isChecked());

This comment has been minimized.

@BachirAmiri

BachirAmiri Mar 20, 2016

It's better i agree

@BachirAmiri

BachirAmiri Mar 20, 2016

It's better i agree

@BachirAmiri

This comment has been minimized.

Show comment
Hide comment
@BachirAmiri

BachirAmiri Mar 20, 2016

Alright i'll do the changes soon , my bad, i guess i was not focused enough

Alright i'll do the changes soon , my bad, i guess i was not focused enough

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 20, 2016

Member

Instead of closing (and opening a new PR) you can also add another commit oO

Member

Ghabry commented Mar 20, 2016

Instead of closing (and opening a new PR) you can also add another commit oO

@BachirAmiri

This comment has been minimized.

Show comment
Hide comment
@BachirAmiri

BachirAmiri Mar 20, 2016

Sorry i wasn't sure about the right procedure , i've done changes , should i just commit with another name and push like first time ?

Sorry i wasn't sure about the right procedure , i've done changes , should i just commit with another name and push like first time ?

@BachirAmiri BachirAmiri reopened this Mar 20, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 20, 2016

Member

Just commit to the branch you used to create this pull request and push. Then the commit will be added to this PR.

PR are improving over time, so this is fine.

Member

Ghabry commented Mar 20, 2016

Just commit to the branch you used to create this pull request and push. Then the commit will be added to this PR.

PR are improving over time, so this is fine.

@BachirAmiri

This comment has been minimized.

Show comment
Hide comment
@BachirAmiri

BachirAmiri Mar 20, 2016

Thank you ! hope this one will fit !

Thank you ! hope this one will fit !

Show outdated Hide outdated builds/android/src/org/easyrpg/player/SettingsActivity.java
@@ -32,6 +32,7 @@
import android.widget.SeekBar;
import android.widget.SeekBar.OnSeekBarChangeListener;
import android.widget.TextView;
import android.media.MediaPlayer;

This comment has been minimized.

@carstene1ns

carstene1ns Mar 20, 2016

Member

Is this one needed? Seems like a leftover.

@carstene1ns

carstene1ns Mar 20, 2016

Member

Is this one needed? Seems like a leftover.

This comment has been minimized.

@BachirAmiri

BachirAmiri Mar 20, 2016

Yeah got it !

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 20, 2016

Member

Jenkins: Test this please

Member

Ghabry commented Mar 20, 2016

Jenkins: Test this please

Ghabry added a commit that referenced this pull request Mar 20, 2016

Merge pull request #835 from Souigetsu/master
Adding the possibility to disable sounds in app settings

@Ghabry Ghabry merged commit 7c7edc8 into EasyRPG:master Mar 20, 2016

5 checks passed

Android Build finished.
Details
Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry modified the milestone: 0.4.2 Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment