New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class handling #921

Merged
merged 5 commits into from Jul 9, 2016

Conversation

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented Jul 7, 2016

Classes are handled silly in RPG Maker 2003. The class settings don't matter at all on startup (it only shows the class name in the status scene), everything else is only applied when "Change Class" event is used...

The naming in liblcf is really inconsistent what do you think about adjusting this?

mighty_guard <-> super_guard
lock_equipment <-> fix_equipment
two_weapon <-> two_swords_style

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 7, 2016

Member

Is sword the only weapon that can be used two-handed? I guess no, so weapon should be the right term here (and not caring, whatever rpg maker uses here, their translation is not good in some other cases too).

Member

carstene1ns commented Jul 7, 2016

Is sword the only weapon that can be used two-handed? I guess no, so weapon should be the right term here (and not caring, whatever rpg maker uses here, their translation is not good in some other cases too).

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 7, 2016

Member

The problem here is that liblcf has two different names for the same things depending on if you look in RPG::Actor, RPG::Class or RPG::SaveActor.

two_weapon is obviously better then two_swords_style, bad translation.

And two handed doesn't fit because it's not a single weapon for 2 hands but 2 weapons for 2 hands and no shield :D

Member

Ghabry commented Jul 7, 2016

The problem here is that liblcf has two different names for the same things depending on if you look in RPG::Actor, RPG::Class or RPG::SaveActor.

two_weapon is obviously better then two_swords_style, bad translation.

And two handed doesn't fit because it's not a single weapon for 2 hands but 2 weapons for 2 hands and no shield :D

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 9, 2016

Member

jenkins: test this please

Member

carstene1ns commented Jul 9, 2016

jenkins: test this please

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 9, 2016

Member

Do you want to rename bool Game_Actor::GetTwoSwordsStyle() too or should it stay this way?

Member

carstene1ns commented Jul 9, 2016

Do you want to rename bool Game_Actor::GetTwoSwordsStyle() too or should it stay this way?

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 9, 2016

Member

good point, gimme a moment

Member

Ghabry commented Jul 9, 2016

good point, gimme a moment

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 9, 2016

Member

looks good to me now, merging after jenkins is ready.

Member

carstene1ns commented Jul 9, 2016

looks good to me now, merging after jenkins is ready.

@carstene1ns carstene1ns merged commit 7df0af5 into EasyRPG:master Jul 9, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment