New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android : new GameBrowser #925

Merged
merged 10 commits into from Aug 6, 2016

Conversation

Projects
None yet
5 participants
@BlisterB
Member

BlisterB commented Jul 10, 2016

Hello everyone!

Here is the result of those two days of works :

  • I made a new GameBrowser for API > 15, hope you'll like it!
  • Now we target API 23 but I managed to keep the min SDK to 10. I needed to adapt a lot of things but this sounds to works good ^^.
  • I cleaned some part of code (this part is not over).
  • I fixed some bug not reported.
  • I've put a beautiful flashy setting button on the main activity, at the sight of everyone.

This pull request is not over, but I prefer to do this pull request to collect some feedbacks before finish it (I can't code for a week).

What remains to :

  • Deal with the new permission system of Android 6
    <!> : If you are running on Android 6+, you have to manually give permission to the app (in Android Preferences). If you don't do this, the app cannot access to internal and external storage (don't forget we're dealing with Android platform hahaha).
  • Do the "Share" feature
  • Collect feedback and bugreport.
  • Continue to clean the code.
  • Refund the Settings Activity (with category and a uniform UI with the main activity)
  • The .nomedia seems to not be added to new game directory
@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 10, 2016

Member

Oh, we will probably have to slightly change the build script, to fit with the new target sdk.

Member

BlisterB commented Jul 10, 2016

Oh, we will probably have to slightly change the build script, to fit with the new target sdk.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 10, 2016

Member

Sounds cool. Can you show some screenshots of the new browser?

Member

Ghabry commented Jul 10, 2016

Sounds cool. Can you show some screenshots of the new browser?

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

Of course, here are some screenshots :


Member

BlisterB commented Jul 11, 2016

Of course, here are some screenshots :


@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 11, 2016

Member

May I get the new Android build line? :)

Member

Ghabry commented Jul 11, 2016

May I get the new Android build line? :)

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 11, 2016

Member

I installed on the server (in the toolchain dir, will push this to buildscripts when ready :D):

android update sdk -u -a -t android-23
android update sdk -u -a -t extra-android-support

Which is API23 and Android Support Lib

A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugCompile'.
   > Could not find com.android.support:appcompat-v7:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/appcompat-v7/23.2.1/appcompat-v7-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/appcompat-v7/23.2.1/appcompat-v7-23.2.1.jar
     Required by:
         android:app:unspecified
   > Could not find com.android.support:design:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/design/23.2.1/design-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/design/23.2.1/design-23.2.1.jar
     Required by:
         android:app:unspecified
   > Could not find com.android.support:cardview-v7:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/cardview-v7/23.2.1/cardview-v7-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/cardview-v7/23.2.1/cardview-v7-23.2.1.jar
     Required by:
         android:app:unspecified
   > Could not find com.android.support:recyclerview-v7:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/recyclerview-v7/23.2.1/recyclerview-v7-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/recyclerview-v7/23.2.1/recyclerview-v7-23.2.1.jar
     Required by:
         android:app:unspecified
Member

Ghabry commented Jul 11, 2016

I installed on the server (in the toolchain dir, will push this to buildscripts when ready :D):

android update sdk -u -a -t android-23
android update sdk -u -a -t extra-android-support

Which is API23 and Android Support Lib

A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugCompile'.
   > Could not find com.android.support:appcompat-v7:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/appcompat-v7/23.2.1/appcompat-v7-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/appcompat-v7/23.2.1/appcompat-v7-23.2.1.jar
     Required by:
         android:app:unspecified
   > Could not find com.android.support:design:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/design/23.2.1/design-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/design/23.2.1/design-23.2.1.jar
     Required by:
         android:app:unspecified
   > Could not find com.android.support:cardview-v7:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/cardview-v7/23.2.1/cardview-v7-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/cardview-v7/23.2.1/cardview-v7-23.2.1.jar
     Required by:
         android:app:unspecified
   > Could not find com.android.support:recyclerview-v7:23.2.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/support/recyclerview-v7/23.2.1/recyclerview-v7-23.2.1.pom
         https://jcenter.bintray.com/com/android/support/recyclerview-v7/23.2.1/recyclerview-v7-23.2.1.jar
     Required by:
         android:app:unspecified
@ItsSchoko

This comment has been minimized.

Show comment
Hide comment
@ItsSchoko

ItsSchoko Jul 11, 2016

Hey there, good to see that someone is going the same way. :D

I've just made a short demo clip of the current status:
https://youtu.be/-U3OpDch92E

For some inspiration, I also add my mockup graphic which I created before programming the UI:
-- outdated, will update this picture later on --

The UI itself is minSDK10 and maxSDK23, had some minor problems like white backgrounds and stuff, because 4.4 doesn't inherit the background.

I also plan to make a second list view option for larger screens (e.g. TV), like in your screenshots.

And here's a DropBox link to an APK of the current status:
https://www.dropbox.com/sh/0zqznc8x7v7sar5/AABKnTtuuWQRa9Dbmh2mJZN6a/UI/APK

ItsSchoko commented Jul 11, 2016

Hey there, good to see that someone is going the same way. :D

I've just made a short demo clip of the current status:
https://youtu.be/-U3OpDch92E

For some inspiration, I also add my mockup graphic which I created before programming the UI:
-- outdated, will update this picture later on --

The UI itself is minSDK10 and maxSDK23, had some minor problems like white backgrounds and stuff, because 4.4 doesn't inherit the background.

I also plan to make a second list view option for larger screens (e.g. TV), like in your screenshots.

And here's a DropBox link to an APK of the current status:
https://www.dropbox.com/sh/0zqznc8x7v7sar5/AABKnTtuuWQRa9Dbmh2mJZN6a/UI/APK

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

@Ghabry : I've updated the dependencies following this stack :
http://stackoverflow.com/questions/29284236/failed-to-resolve-com-android-supportappcompat-v722-and-com-android-supportre

@ItsSchoko : Your UI is nice, I'm curious to see the final result, especially for the settings activity (I don't have the time to redo it).
Nevertheless I don't really like the new Button Layout, I like the current one which stay discreet.

Member

BlisterB commented Jul 11, 2016

@Ghabry : I've updated the dependencies following this stack :
http://stackoverflow.com/questions/29284236/failed-to-resolve-com-android-supportappcompat-v722-and-com-android-supportre

@ItsSchoko : Your UI is nice, I'm curious to see the final result, especially for the settings activity (I don't have the time to redo it).
Nevertheless I don't really like the new Button Layout, I like the current one which stay discreet.

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

I had the time to watch the video. This is really nice.
Considering this work, I'll cut some functionality for this Pull Request and just do the permission asking (don't do the Share functionnality and remake the Settings activity). This GameBrowser will be avaible until @ItsSchoko will finish his own, to decide which one will be our futur base work.

Member

BlisterB commented Jul 11, 2016

I had the time to watch the video. This is really nice.
Considering this work, I'll cut some functionality for this Pull Request and just do the permission asking (don't do the Share functionnality and remake the Settings activity). This GameBrowser will be avaible until @ItsSchoko will finish his own, to decide which one will be our futur base work.

@ItsSchoko

This comment has been minimized.

Show comment
Hide comment
@ItsSchoko

ItsSchoko Jul 11, 2016

@BlisterB I'm curious too, it's still a long way to go.
This Button Layout is part of some extra button sets I've created, I'm just too lazy to use the old ones inside the mockup project. (There are also flat discreet ones)
My Plan is to rework the Button Layout Editor, which then should work with .svg files, color change, scaling, etc.

A lot of comments on the Playstore just scream for better usability, which I try to reach.
I know a lot of you guys are busy with core features, so I decided to help in creating a better enduser UI experience with my first app.

EDIT: One minor detail, the app itself can't start games for now, so the "games" you see are just some dummy list entries, still have to combine a lot of the core features with the UI.

ItsSchoko commented Jul 11, 2016

@BlisterB I'm curious too, it's still a long way to go.
This Button Layout is part of some extra button sets I've created, I'm just too lazy to use the old ones inside the mockup project. (There are also flat discreet ones)
My Plan is to rework the Button Layout Editor, which then should work with .svg files, color change, scaling, etc.

A lot of comments on the Playstore just scream for better usability, which I try to reach.
I know a lot of you guys are busy with core features, so I decided to help in creating a better enduser UI experience with my first app.

EDIT: One minor detail, the app itself can't start games for now, so the "games" you see are just some dummy list entries, still have to combine a lot of the core features with the UI.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 11, 2016

Member

@BlisterB
https://gradleplease.appspot.com/
Could you try this settings? (change the file, do a "git commit -a --amend" and "git push -f") ;)

I installed now also the 2 maven repos, no change.

Member

Ghabry commented Jul 11, 2016

@BlisterB
https://gradleplease.appspot.com/
Could you try this settings? (change the file, do a "git commit -a --amend" and "git push -f") ;)

I installed now also the 2 maven repos, no change.

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

Yeah until recently we were unable to use external dependencies so it was impossible to use something API > 10 and it was difficult to do beautifull things. And as I am not student anymore my time si shorter :/.

Your UI is really nice, but please pay attention with the dependencies that we can found on the web : they must be compliant with our licences (which is a beautifull bottleneck hahaha).

@Ghabry : Okay!

Member

BlisterB commented Jul 11, 2016

Yeah until recently we were unable to use external dependencies so it was impossible to use something API > 10 and it was difficult to do beautifull things. And as I am not student anymore my time si shorter :/.

Your UI is really nice, but please pay attention with the dependencies that we can found on the web : they must be compliant with our licences (which is a beautifull bottleneck hahaha).

@Ghabry : Okay!

@ItsSchoko

This comment has been minimized.

Show comment
Hide comment
@ItsSchoko

ItsSchoko Jul 11, 2016

@BlisterB Already got that covered.

  • the Navigation Menu icons are Google system icons https://design.google.com/icons/index.html
  • the game icons are just there to illustrate what you will see, so in the end only content from the games you have "installed" are loaded into the list.
  • and the rest are my own creations (mockup phones, buttons sets etc.) or from EasyRPG (two exceptions: facebook and twitter logo, which later should also get some copyright entries)

ItsSchoko commented Jul 11, 2016

@BlisterB Already got that covered.

  • the Navigation Menu icons are Google system icons https://design.google.com/icons/index.html
  • the game icons are just there to illustrate what you will see, so in the end only content from the games you have "installed" are loaded into the list.
  • and the rest are my own creations (mockup phones, buttons sets etc.) or from EasyRPG (two exceptions: facebook and twitter logo, which later should also get some copyright entries)
fix android dependencies
Android Use 23.4.0 dependencies
@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

Okay, sounds cool!

@Ghabry : I did what you've asked :).

Member

BlisterB commented Jul 11, 2016

Okay, sounds cool!

@Ghabry : I did what you've asked :).

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 11, 2016

Member

@BlisterB
Do I have to install Maven and download the support library dependencies manually? Because the repository folder is almost empty.

Member

Ghabry commented Jul 11, 2016

@BlisterB
Do I have to install Maven and download the support library dependencies manually? Because the repository folder is almost empty.

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

Nope, everything works with gradle,
I think you're right, this is what seems to tell this PR : http://stackoverflow.com/questions/36222111/android-could-not-find-com-android-supportsupport-v423-2-1 .

Member

BlisterB commented Jul 11, 2016

Nope, everything works with gradle,
I think you're right, this is what seems to tell this PR : http://stackoverflow.com/questions/36222111/android-could-not-find-com-android-supportsupport-v423-2-1 .

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry
Member

Ghabry commented Jul 11, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 11, 2016

Member

One obvious problem of your Title folder scanning is: It will pick the wrong one when there is more then 1 file in it... But to get the correct one you would need to parse the RPG_RT.ldb :D

And guess the encoding... lets wait for a liblcf update, too much hassle to code in Java again.

Oh and @BlisterB could you make a small change to the "Select Layout" game menu? A button "Edit layout" that scrolls to the layout settings of the settings ui would be useful.

Member

Ghabry commented Jul 11, 2016

One obvious problem of your Title folder scanning is: It will pick the wrong one when there is more then 1 file in it... But to get the correct one you would need to parse the RPG_RT.ldb :D

And guess the encoding... lets wait for a liblcf update, too much hassle to code in Java again.

Oh and @BlisterB could you make a small change to the "Select Layout" game menu? A button "Edit layout" that scrolls to the layout settings of the settings ui would be useful.

@fdelapena fdelapena added the Android label Jul 11, 2016

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

Ghabry : yeeees the title screen is very dumb I agree but it would be a mess to integrate ldb parsing and terrible for performances :p.
I'll do the select layout feature for the game menu :).

Member

BlisterB commented Jul 11, 2016

Ghabry : yeeees the title screen is very dumb I agree but it would be a mess to integrate ldb parsing and terrible for performances :p.
I'll do the select layout feature for the game menu :).

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 11, 2016

Member

@Ghabry Now the app ask for storage permission (this thing is awfull to handle in android code).
For the edit button in the select layout, I checked and this is always not possible to do this quickly without creating a whole new class.
Because I won't be free for a week I think I'm over for this PR and I add the things I didn't in the Android to do list thread.
Of course if something bother you don't hesitate to tell me :).

Member

BlisterB commented Jul 11, 2016

@Ghabry Now the app ask for storage permission (this thing is awfull to handle in android code).
For the edit button in the select layout, I checked and this is always not possible to do this quickly without creating a whole new class.
Because I won't be free for a week I think I'm over for this PR and I add the things I didn't in the Android to do list thread.
Of course if something bother you don't hesitate to tell me :).

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 11, 2016

Member

Okay I will keep this PR on hold then until I have time to do more testing. Pushing this directly to the Android users is a bit risky because it's workweek :D

Member

Ghabry commented Jul 11, 2016

Okay I will keep this PR on hold then until I have time to do more testing. Pushing this directly to the Android users is a bit risky because it's workweek :D

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 21, 2016

Member

Hi everyone, I'm back with an Java 8 OCA in my pocket hihihi ^^.

@Ghabry Do you have suggestions for this PR?

Member

BlisterB commented Jul 21, 2016

Hi everyone, I'm back with an Java 8 OCA in my pocket hihihi ^^.

@Ghabry Do you have suggestions for this PR?

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 21, 2016

Member

@BlisterB
Imo the game title graphics in your tile view should depend on the screen size... Currently gigantic and small displays get 2 games per row. And the aspect ratio isn't correct (title graphics are cut, not the whole 320x240 graphic is rendered).

But my bigger worry is that some users will probably hate this view and show all there hate with 1 star ratings!
Maybe you could add a button to toggle between tile and list view? Basicly like in the mockup of Schoko. Small title graphic on the left, followed by game title. Is more space friendly.
But really depends on who you ask, both view options make sense.

Member

Ghabry commented Jul 21, 2016

@BlisterB
Imo the game title graphics in your tile view should depend on the screen size... Currently gigantic and small displays get 2 games per row. And the aspect ratio isn't correct (title graphics are cut, not the whole 320x240 graphic is rendered).

But my bigger worry is that some users will probably hate this view and show all there hate with 1 star ratings!
Maybe you could add a button to toggle between tile and list view? Basicly like in the mockup of Schoko. Small title graphic on the left, followed by game title. Is more space friendly.
But really depends on who you ask, both view options make sense.

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 30, 2016

Member

Hahaha

Member

BlisterB commented Jul 30, 2016

Hahaha

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 30, 2016

Member

One minor issue:
When the browser starts in landscape (or you return from a game while in landscape) the left and right padding is much bigger then when starting in Portrait and rotating to landscape #Android -.-

screenshot_2016-07-30-16-05-18

For compare the correct padding (portrait and rotated then)
screenshot_2016-07-29-23-17-33

Member

Ghabry commented Jul 30, 2016

One minor issue:
When the browser starts in landscape (or you return from a game while in landscape) the left and right padding is much bigger then when starting in Portrait and rotating to landscape #Android -.-

screenshot_2016-07-30-16-05-18

For compare the correct padding (portrait and rotated then)
screenshot_2016-07-29-23-17-33

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 30, 2016

Member

@Ghabry does my last commit solved your problem?
It seems this way to obtain the screen width is better than using the Configuration object.

Member

BlisterB commented Jul 30, 2016

@Ghabry does my last commit solved your problem?
It seems this way to obtain the screen width is better than using the Configuration object.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 30, 2016

Member

Not fixed. Maybe you could test it in an emulator?

Member

Ghabry commented Jul 30, 2016

Not fixed. Maybe you could test it in an emulator?

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Jul 30, 2016

Member

Y-e-s I'm using multiple VM to test the GameBrowser. But I didn't faced this problem.
Could you give me some information about your model (screen size, android version, eventually the manufacturer if a friend have a similar model), or at least tell me if your fix (the file deletion) worked?

Please remember that Android platform is a mess, possibly every Android version/model could give a slightly different result.

Member

BlisterB commented Jul 30, 2016

Y-e-s I'm using multiple VM to test the GameBrowser. But I didn't faced this problem.
Could you give me some information about your model (screen size, android version, eventually the manufacturer if a friend have a similar model), or at least tell me if your fix (the file deletion) worked?

Please remember that Android platform is a mess, possibly every Android version/model could give a slightly different result.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 31, 2016

Member

Oh, okay :D
It's a Android 4.1 Samsung(!) Galaxy Note.

Size 8.0 inches (~64.8% screen-to-body ratio)
Resolution 800 x 1280 pixels (~189 ppi pixel density)

Member

Ghabry commented Jul 31, 2016

Oh, okay :D
It's a Android 4.1 Samsung(!) Galaxy Note.

Size 8.0 inches (~64.8% screen-to-body ratio)
Resolution 800 x 1280 pixels (~189 ppi pixel density)

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 6, 2016

Member

I succeed in reproducing the layout bug, please excuse me for the long waiting time, your fix was the right solution @Ghabry.
I also deleted the previous commit which became useless.

Member

BlisterB commented Aug 6, 2016

I succeed in reproducing the layout bug, please excuse me for the long waiting time, your fix was the right solution @Ghabry.
I also deleted the previous commit which became useless.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 6, 2016

Member

In my opinion this can be merged now. Anybody with further criticism?

Member

Ghabry commented Aug 6, 2016

In my opinion this can be merged now. Anybody with further criticism?

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Aug 6, 2016

Member

I just hope transifex does not burp on the whitespace change, otherwise ok.

Member

carstene1ns commented Aug 6, 2016

I just hope transifex does not burp on the whitespace change, otherwise ok.

@Ghabry Ghabry merged commit 95ade95 into EasyRPG:master Aug 6, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 6, 2016

Member

Burped a bit. @BlisterB , any idea where these localizations are coming from? :o

screenshot_20160807_001332

Member

Ghabry commented Aug 6, 2016

Burped a bit. @BlisterB , any idea where these localizations are coming from? :o

screenshot_20160807_001332

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 6, 2016

Member

Wtf, where does this come from oO.

Member

BlisterB commented Aug 6, 2016

Wtf, where does this come from oO.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry
Member

Ghabry commented Aug 6, 2016

wtfandroid

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 6, 2016

Member

As @carstene1ns guessed the languages are part of the appcompat lib. I just looked in one of the appcompat files with nano and found references to values-[langcode] files that match the ones on the screenshot.

Member

Ghabry commented Aug 6, 2016

As @carstene1ns guessed the languages are part of the appcompat lib. I just looked in one of the appcompat files with nano and found references to values-[langcode] files that match the ones on the screenshot.

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 6, 2016

Member

Hmm, is this something severe?

Member

BlisterB commented Aug 6, 2016

Hmm, is this something severe?

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 6, 2016

Member

No, we agreed on the chat to ignore it. Too much work to "solve".

Member

Ghabry commented Aug 6, 2016

No, we agreed on the chat to ignore it. Too much work to "solve".

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 6, 2016

Member

Okay

Member

BlisterB commented Aug 6, 2016

Okay

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 6, 2016

Member

I'm currently cleaning the Settings Activity, I'm pretty ashamed to have done something so dirty huhuhu.

Member

BlisterB commented Aug 6, 2016

I'm currently cleaning the Settings Activity, I'm pretty ashamed to have done something so dirty huhuhu.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 6, 2016

Member

APK is published. I will forward all crash reports here tomorrow. Good night.

Member

Ghabry commented Aug 6, 2016

APK is published. I will forward all crash reports here tomorrow. Good night.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 8, 2016

Member

@BlisterB
Users are happy. no feedback at all, neither positive nor negative. So must be good when nobody complains ;)
Also no crashes received.

Member

Ghabry commented Aug 8, 2016

@BlisterB
Users are happy. no feedback at all, neither positive nor negative. So must be good when nobody complains ;)
Also no crashes received.

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 8, 2016

Member

This is a good news ^^.
I intend to improve the code related to Preferences Activity which is actually awfull, and do an improvment of the portrait mode inspired by the ItsSchoko mock up (because the actual layout take obviously too much space). Before starting the study for the Oracle Java OCP huhuhu.

Member

BlisterB commented Aug 8, 2016

This is a good news ^^.
I intend to improve the code related to Preferences Activity which is actually awfull, and do an improvment of the portrait mode inspired by the ItsSchoko mock up (because the actual layout take obviously too much space). Before starting the study for the Oracle Java OCP huhuhu.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 8, 2016

Member

You can also think about how to make it more obvious how to edit layouts because we found a user who couldn't figure out to press the "back button" to open the menu ;)

Member

Ghabry commented Aug 8, 2016

You can also think about how to make it more obvious how to edit layouts because we found a user who couldn't figure out to press the "back button" to open the menu ;)

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Aug 8, 2016

Member

lol
I find nothing more relevant to say

Member

BlisterB commented Aug 8, 2016

lol
I find nothing more relevant to say

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 16, 2016

Member

@BlisterB
A small update about how the people like the Game Browser: By now still no feedback (and no crashes) but our average rating increased over the last weeks and somehow most ratings are now 4 and 5 stars. I can't say that this is a correlation with your browser (we also had many other game fixes) but at least the amount of stupid questions reduced, looks like most people find the settings now.

One person even changed her rating to 5 stars because they were happy that adding shift is possible now m(

Member

Ghabry commented Aug 16, 2016

@BlisterB
A small update about how the people like the Game Browser: By now still no feedback (and no crashes) but our average rating increased over the last weeks and somehow most ratings are now 4 and 5 stars. I can't say that this is a correlation with your browser (we also had many other game fixes) but at least the amount of stupid questions reduced, looks like most people find the settings now.

One person even changed her rating to 5 stars because they were happy that adding shift is possible now m(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment