New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs in Ib #946

Merged
merged 2 commits into from Jul 24, 2016

Conversation

Projects
None yet
4 participants
@Zegeri
Member

Zegeri commented Jul 24, 2016

  • Fixes the moving statue of the Yellow Space randomly disappearing
  • Fixes hang after Garry heads up the stairs after the the Disturbing Doll room (thanks to android user Ren)
@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 24, 2016

Member

3ee94fb looks like it could potentially fix some other sprite issues. The Velsarbor opening glitches are still present, though.
About the Disturbing Doll room, I think you do not mean the one with the "Red Eyes" rabbit painting, because there are no stairs for Garry afterwards. Only Ib and Mary have the one with the red paint ball (map id 57), which does not lock up. Can I have a map id to playtest this?

Member

carstene1ns commented Jul 24, 2016

3ee94fb looks like it could potentially fix some other sprite issues. The Velsarbor opening glitches are still present, though.
About the Disturbing Doll room, I think you do not mean the one with the "Red Eyes" rabbit painting, because there are no stairs for Garry afterwards. Only Ib and Mary have the one with the red paint ball (map id 57), which does not lock up. Can I have a map id to playtest this?

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 24, 2016

Member

Okay, already found it (after reading the bug report mail). It is actually the second room with the dolls, where you need to find the key inside the dolls before the time runs out (forgot about this^^').
Yes, this PR fixes the hang while faded out when switching to Ib afterwards, so 👍 from me.

Member

carstene1ns commented Jul 24, 2016

Okay, already found it (after reading the bug report mail). It is actually the second room with the dolls, where you need to find the key inside the dolls before the time runs out (forgot about this^^').
Yes, this PR fixes the hang while faded out when switching to Ib afterwards, so 👍 from me.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 24, 2016

Member

Look good to me 👍

Member

Ghabry commented Jul 24, 2016

Look good to me 👍

@fdelapena fdelapena merged commit bc088ef into EasyRPG:master Jul 24, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fdelapena fdelapena added this to the 0.5.0 milestone Jul 24, 2016

@fdelapena

This comment has been minimized.

Show comment
Hide comment
@fdelapena

fdelapena Jul 24, 2016

Contributor

Also fixes a hang in Doraemon Nobita's Resident Evil after the first playable teleport recently reported too. 👍.

Contributor

fdelapena commented Jul 24, 2016

Also fixes a hang in Doraemon Nobita's Resident Evil after the first playable teleport recently reported too. 👍.

@Zegeri Zegeri deleted the Zegeri:ib-hotfix branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment