Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yume2kki ugliness #978

Merged
merged 4 commits into from Aug 12, 2016

Conversation

@Ghabry
Copy link
Member

commented Aug 7, 2016

This game is stupid and has invalid inventory in the slots.
The weapon contains a switch e.g., RPG_RT filters this and the editor shows it as (None) but the database still contains the value. Way to go Enterbrain!

Furthermore this 350 MB games saves tons of space cough by crossreferencing files via
Panorama..\Title\Title3, nice, that path is now rewritten to Title\Title3 by the FileFinder.
I also tested files directly in the root directory (Panorama..\Title3), becomes Title3 馃憤
That strange feature is only used when filefinder path != canonical, so only happens when "." or ".." is a path component which can't happen when using the editor without hex editing.

@Ghabry Ghabry force-pushed the Ghabry:yume2kki branch 2 times, most recently from 3c1de8e to a565802 Aug 7, 2016

@carstene1ns

This comment has been minimized.

Copy link
Member

commented Aug 7, 2016

Will test this later. Hope we find other games fixed by this using our Android userbase... 馃榾

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2016

I also want to check if i simplify the lookup for ineluki mp3 due to these changes here

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2016

No can't simplify ineluki, the canonical path is also used for debug log. Even if this would only save one line... ;)

Ghabry added 2 commits Aug 7, 2016
Filter out items that are not allowed in the assigned item slot. Fixes
鈥#977

Yume2kki has for some reasons a weapon in the weapon slot that is actually a switch.
Support lookup in FileFinder when the name is not canonical. E.g. Pan鈥
鈥rama with file ..\Title\Title. Fixes #976

Some games (Yume2kki e.g.) use hex edited names that contain a ..\ in the path to read outside of the expected directory.

@Ghabry Ghabry force-pushed the Ghabry:yume2kki branch from a565802 to b0971b6 Aug 8, 2016

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2016

this is ready for testing now.

@Ghabry Ghabry force-pushed the Ghabry:yume2kki branch from b0971b6 to a943a0b Aug 8, 2016

@Ghabry

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2016

The invalid equipment filtering is a gigantic clusterfuck. Happens in like 33% of my games :o

Expect complains of users losing items because I also clean up when loading saves ;)

Don't use the Player escape_symbol in SplitPath when it is not initia鈥
鈥ized yet because the encoding isn't detected yet.

@fdelapena fdelapena merged commit ab5e7d6 into EasyRPG:master Aug 12, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:yume2kki branch Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.