Skip to content

lmu2png: Add wxWidgets GUI - #89

Merged
Ghabry merged 2 commits into
EasyRPG:masterfrom
carstene1ns:feature/lmu-gui
Nov 9, 2024
Merged

Ghabry merged 2 commits into
EasyRPG:masterfrom
carstene1ns:feature/lmu-gui

Conversation

@carstene1ns

Copy link
Copy Markdown
Member

used

Also, multiple RTP dirs are now supported (like in Player).

@Ghabry
Ghabry self-requested a review May 20, 2024 21:10
@Ghabry

Ghabry commented May 25, 2024

Copy link
Copy Markdown
Member

That is great!

I almost got this to build on Windows for testing :) (wx builds fine with vcpkg, but there is a problem with this ancient SDL_image.cmake file we use, fix in progress)

@carstene1ns

Copy link
Copy Markdown
Member Author

I have a local branch that replaces SDL with freeimage, not finished yet though.
Made a minimal fork to use on jenkins, but of course compatible with distro packages.

https://github.com/carstene1ns/freeimage-easyrpg

@Ghabry

Ghabry commented May 26, 2024

Copy link
Copy Markdown
Member

Ah okay in that case I can skip the work on fixing cmake :)

@Ghabry

Ghabry commented Aug 25, 2024

Copy link
Copy Markdown
Member

Saving fails with "no image handler for type 15" defined but rendering works...

Image becomes glitched when resizing the window.

grafik

@Ghabry

Ghabry commented Aug 25, 2024

Copy link
Copy Markdown
Member

To fix PNG saving you must call wxImage::AddHandler(new wxPNGHandler); once, e.g. on startup. Weird this isn't needed on Linux as the doc says only the BMP handler is loaded by default.

Cleanup is not necessary:

A heap-allocated handler object which will be deleted by wxImage if it is removed later by RemoveHandler() or at program shutdown.

@Ghabry

Ghabry commented Oct 16, 2024

Copy link
Copy Markdown
Member

Jenkins: test this please

@Ghabry

Ghabry commented Nov 3, 2024

Copy link
Copy Markdown
Member

@carstene1ns this obviously has some conflicts now but freeimage and wx on Windows should be working now :)

@carstene1ns

Copy link
Copy Markdown
Member Author

Yeah, will adapt this sometime in the next days.

@carstene1ns

Copy link
Copy Markdown
Member Author

Please test, it works for me™

@Ghabry

Ghabry commented Nov 7, 2024

Copy link
Copy Markdown
Member

Impressive error message from Windows global namespace pollution. Have to boot Windows to figure this mess out >.>

@Ghabry
Ghabry merged commit 0772ab7 into EasyRPG:master Nov 9, 2024
@carstene1ns
carstene1ns deleted the feature/lmu-gui branch November 12, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants