Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MapInfo::encounter_steps to MapInfo::encounter_rate #265

Closed
fmatthew5876 opened this issue Oct 17, 2018 · 4 comments · Fixed by #456
Closed

Rename MapInfo::encounter_steps to MapInfo::encounter_rate #265

fmatthew5876 opened this issue Oct 17, 2018 · 4 comments · Fixed by #456
Assignees
Labels
Milestone

Comments

@fmatthew5876
Copy link
Contributor

Leaving this one as a note to remember to do this later when we get the backlog of PR's merged in.

@Zegeri
Copy link
Member

Zegeri commented Oct 26, 2018

encounter_rate could mislead people into thinking that it's a ratio. For example, some people could understand encounter_rate = 10 as "10% chance of an encounter". encounter_steps leads to the correct interpretation, in my opinion.

@fmatthew5876
Copy link
Contributor Author

fmatthew5876 commented Oct 27, 2018

I like encounter_steps, but then we need a different name for SavePartyLocation::encounter_steps.

We currently have these:

  1. MapInfo::encounter_steps
  2. SaveMapInfo::encounter_rate
  3. Terrain::encounter_rate
  4. SavePartyLocation::encounter_steps

(1) and (2) need the same name. I think (3) is appropriate because it's really a multiplier. (4) needs to be differentiated from (1) and (2). It's the number of steps at run time as the encounter algorithm runs.

@fmatthew5876
Copy link
Contributor Author

We also have Game_Map::SetEncounterRate() and Game_Map::GetEncounterRate().

@Ghabry Ghabry added this to the 0.7.0 milestone Sep 2, 2021
@Ghabry Ghabry modified the milestones: 0.7.0, 0.7.1 Oct 24, 2021
@Ghabry
Copy link
Member

Ghabry commented Apr 25, 2023

will add this one quickly before 0.8. Must have forgotten this one while renaming the other chunks.

@Ghabry Ghabry self-assigned this Apr 25, 2023
Ghabry added a commit to Ghabry/easyrpg-liblcf that referenced this issue Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants