-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MapInfo::encounter_steps to MapInfo::encounter_rate #265
Comments
encounter_rate could mislead people into thinking that it's a ratio. For example, some people could understand encounter_rate = 10 as "10% chance of an encounter". encounter_steps leads to the correct interpretation, in my opinion. |
I like encounter_steps, but then we need a different name for We currently have these:
(1) and (2) need the same name. I think (3) is appropriate because it's really a multiplier. (4) needs to be differentiated from (1) and (2). It's the number of steps at run time as the encounter algorithm runs. |
We also have |
will add this one quickly before 0.8. Must have forgotten this one while renaming the other chunks. |
Leaving this one as a note to remember to do this later when we get the backlog of PR's merged in.
The text was updated successfully, but these errors were encountered: