-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace and organize lcf headers #342
Comments
|
As a first step, we could move There are some parts of the liblcf parser that depends on grabbing stuff from |
I'd like to propose we do this header file and namespace change sometime when we cut 6.2 release. The main thing blocking me from doing it now is rebase hell. I wouldn't want to make a namespace PR here and in Player and have it stay for a long time and cause lots of rebase conflicts with other PRs. Seems like right before a release when we have a rush to get everything in would be a good time to cut over. |
moving this to 0.7.0 for now |
Yeah, because nobody makes mistakes when in a rush. 🙄 This is to be done right after a release, not before. |
Ok sure, but maybe we could try to coordinate it, like right after the 6.2 release so it doesn't stay pending too long? This one is a rebase nightmare. |
We need to reorganize the code before we can declare the liblcf API stable.
#include <liblcf/foo.H>
to avoid header conflicts.liblcf
code in anlcf::
namespace.The text was updated successfully, but these errors were encountered: