Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Expat target search #385

Closed
Ghabry opened this issue Aug 22, 2020 · 3 comments
Closed

Improve Expat target search #385

Ghabry opened this issue Aug 22, 2020 · 3 comments

Comments

@Ghabry
Copy link
Member

Ghabry commented Aug 22, 2020

In the meanwhile (at least since 2.2.9 which is from Sep2019, maybe even older versions do this) the expat library is exporting a target expat::expat which replaces the FindEXPAT module. The Find module support should be dropped and only this target referenced instead.

This will break older expat versions but tbh this is an optional dependency on XML is more of a debugging tool.

The target name on Windows is wrong, this is fixed by 2.2.10 which is currently blocked by libexpat/libexpat#415 on Windows.

So I consider this issue blocked until vcpkg updated to 2.2.10 when it is out.

@Ghabry
Copy link
Member Author

Ghabry commented Aug 30, 2020

A patch (not by me) landed in vcpkg which fixed the target. expat::expat is now usable everywhere.

Ghabry added a commit to Ghabry/easyrpg-liblcf that referenced this issue Sep 15, 2020
Ghabry added a commit to Ghabry/easyrpg-liblcf that referenced this issue Sep 15, 2020
@hartwork
Copy link

hartwork commented Oct 4, 2020

So I consider this issue blocked until vcpkg updated to 2.2.10 when it is out.

If that still holds, Expat 2.2.10 is out by now.

@Ghabry
Copy link
Member Author

Ghabry commented Oct 5, 2020

thanks for the info! I already started working on this at #397 . But is currently stuck on other CMake stuff I want to improve ^^'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants