New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reader_struct more fault tolerant and SaveActor::Fixup #175

merged 2 commits into from Mar 16, 2016


None yet
2 participants

Ghabry commented Mar 15, 2016

This fixes problems with the savegame sent by K風鈴 (negima.0824@)

It doesn't load in RPG_RT but looks like a RPG_RT savegame. No idea what happened, the pending field has a strange size. Also the Actor IDs are wrong.

reader_struct realigns now the read pointer when the size is incorrect and shows an error message on the console when this happens.

Ghabry added some commits Mar 15, 2016

Overwrite the ID of the actor with our ID because a bug reported had …
…a save game with invalid IDs values, no idea how this happened.
Make reader_struct more error tolerant by realigning the read pointer…
… instead of generating an assert when a Primitive type has the wrong size. A reported save game has a strange size of 4 for "pending". (See #174)

@Ghabry Ghabry changed the title from Change pending data type and SaveActor::Fixup to Make reader_struct more fault tolerant and SaveActor::Fixup Mar 15, 2016

fdelapena added a commit that referenced this pull request Mar 16, 2016

Merge pull request #175 from Ghabry/development
Make reader_struct more fault tolerant and SaveActor::Fixup

@fdelapena fdelapena merged commit 7d9e325 into EasyRPG:master Mar 16, 2016

4 checks passed

Linux Build finished.
OSX Build finished.
Windows Build finished.
web Build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment