New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide i/o stream API for liblcf #206

Merged
merged 9 commits into from Aug 24, 2017

Conversation

Projects
None yet
4 participants
@Ghabry
Member

Ghabry commented Aug 3, 2017

Finishes the work of ChrisBreiti and provides a compatibility layer around the old function making this change backward compatible 馃憤

The code is required for the WIP filesystem abstraction in Player. FILE* can't be used here because it can only operate on "real" files and we can't use the non-standard fopencookie. Soooooo C++ inheritance to the rescue.

Show outdated Hide outdated src/writer_xml.h Outdated
Fix the INI stream parser. The callback must only return one line whi鈥
鈥h makes the parser code a bit more... interesting

@carstene1ns carstene1ns merged commit 8696809 into EasyRPG:master Aug 24, 2017

4 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 27, 2017

Member

This PR crashes under Android with the useless stacktrace:

********** Crash dump: **********
Build fingerprint: 'Huawei/U8860/hwu8860:4.0.3/HuaweiU8860/CHNC00B932SP01:user/ota-rel-keys,release-keys'
pid: 1766, tid: 1881  >>> org.easyrpg.player <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000000
Stack frame #00  pc 001ddcb8  /data/data/org.easyrpg.player/lib/libmain.so: Routine __exchange_and_add at /tmp/ndk-user/tmp/gnu-libstdc++/static-armeabi-v7athumb-4.8/include/ext/atomicity.h:49
Stack frame #01  pc 001da3d2  /data/data/org.easyrpg.player/lib/libmain.so: Routine std::__timepunct<char>::_M_put(char*, unsigned int, char const*, tm const*) const at /tmp/ndk-user/tmp/gnu-libstdc++/static-armeabi-v7athumb-4.8/src/c++98/time_members.cc:60
Stack frame #02  pc 001c6c26  /data/data/org.easyrpg.player/lib/libmain.so: Routine std::basic_ios<wchar_t, std::char_traits<wchar_t> >::_M_cache_locale(std::locale const&) at /tmp/ndk-user/tmp/gnu-libstdc++/static-armeabi-v7athumb-4.8/include/bits/basic_ios.tcc:170

So our Android build is currently broken.

android-rage-out

Member

Ghabry commented Aug 27, 2017

This PR crashes under Android with the useless stacktrace:

********** Crash dump: **********
Build fingerprint: 'Huawei/U8860/hwu8860:4.0.3/HuaweiU8860/CHNC00B932SP01:user/ota-rel-keys,release-keys'
pid: 1766, tid: 1881  >>> org.easyrpg.player <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000000
Stack frame #00  pc 001ddcb8  /data/data/org.easyrpg.player/lib/libmain.so: Routine __exchange_and_add at /tmp/ndk-user/tmp/gnu-libstdc++/static-armeabi-v7athumb-4.8/include/ext/atomicity.h:49
Stack frame #01  pc 001da3d2  /data/data/org.easyrpg.player/lib/libmain.so: Routine std::__timepunct<char>::_M_put(char*, unsigned int, char const*, tm const*) const at /tmp/ndk-user/tmp/gnu-libstdc++/static-armeabi-v7athumb-4.8/src/c++98/time_members.cc:60
Stack frame #02  pc 001c6c26  /data/data/org.easyrpg.player/lib/libmain.so: Routine std::basic_ios<wchar_t, std::char_traits<wchar_t> >::_M_cache_locale(std::locale const&) at /tmp/ndk-user/tmp/gnu-libstdc++/static-armeabi-v7athumb-4.8/include/bits/basic_ios.tcc:170

So our Android build is currently broken.

android-rage-out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment