Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Detect corrupted chunks and reset the parser #250
Towards addressing #249
This one successfully parses the Devil and Angel ldb. When I copy it, the chunk for the corrupted animation is different, but everything else in the database is a perfect match.
This and other games like like it should load and be playable now in Player.
This doesn't attempt to emulate how rm2k/3 interprets the corrupted chunk.
2 times, most recently
Oct 3, 2018
referenced this pull request
Oct 3, 2018
Defect report for you:
Which means the problem is in general no big deal.
(Marked 0.6.0 because I'm not sure if this fix will break some savegames written by EasyRPG, better don't risk anything :) )
The RPG Maker does the same.
I found it interesting that there were two games (Devil or Angel and Monster Hunter RPG) with the exact same corruption, but in total different locations in the file. I looked at it and saw that they are both based on the same template, which I believe to be an obscure Italian-translated RM2k default database (I guess Monster World was converted from 2k to 2k3).
My guess is that in the world of corrupted downloads 15 years ago, this version was corrupted once and then it spread in some Italian-translated RM2k download...
I do wonder though why this seems to happen almost exclusively in animation timing data. I'm worried that there is some kind of bug in RM (like a buffer overflow or something) which can cause these issues infrequently...
Now that's nothing liblcf can do of course, I just found it interesting nonetheless.