Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how SaveGame Music and sfx are loaded #262

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Oct 12, 2018

If the chunk name is an empty string, it means default the entire chunk to
ldb system, not just the name. That includes name, tempo, volume, balance, etc..

Fixes an issue in Player EasyRPG/Player#985 where battle start SFX tempo was reset to 100 when loading saved games.

Fix how SaveGame Music and sfx are loaded
If the entire block is missing, it means default the whole thing to
system. That includes name, temp, volume, balance, etc..

@carstene1ns carstene1ns added this to the 0.6.0 milestone Oct 14, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Oct 27, 2018

hm this looked simple enough for 0.5.4, well, too late now :)

@Ghabry Ghabry merged commit 384a605 into EasyRPG:master Oct 27, 2018

5 checks passed

GCW0 Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:fix_load_audio branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.