Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake config to autotools-based installs #275

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@carstene1ns
Copy link
Member

carstene1ns commented Nov 1, 2018

Fixes an issue where an old cmake version (<3.10) will not compile
Player, because the needed EXPAT::EXPAT target is not available.

Add cmake config to autotools-based installs
Fixes an issue where an old cmake version (<3.10) will not compile
Player, because the needed EXPAT::EXPAT target is not available.

@fdelapena fdelapena added the Building label Nov 1, 2018

@carstene1ns carstene1ns requested a review from Ghabry Nov 4, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Nov 4, 2018

by looking at strace and some testing I see that CMake doesn't even try to use these "Find*.cmake" files we install there (which means it never worked). Need to play around with this a bit more...

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Nov 4, 2018

I looked at other libraries that bundle Find modules and the solution is using the "include" directive. No idea if this has any unwanted side-effects but for me it works (also added a <3.10 version check as starting with 3.10 EXPAT was added and ICU even earlier...

@Ghabry Ghabry force-pushed the carstene1ns:autotools-cmake-config branch from 7f441b7 to 5d9a8a9 Nov 4, 2018

@Ghabry

Ghabry approved these changes Nov 4, 2018

@carstene1ns

This comment has been minimized.

Copy link
Member Author

carstene1ns commented Nov 5, 2018

Cannot approve my own pull request *g* 👍

@carstene1ns carstene1ns merged commit bac4197 into EasyRPG:master Nov 5, 2018

4 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:autotools-cmake-config branch Nov 5, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Nov 5, 2018

haha yes, couIdnt add you as a reviewer neither.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.