Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SaveActor::row #283

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Nov 24, 2018

Changed it to an enum. The values I use are:

  • 0 - front
  • 1 - back

How did we come up with -1 meaning front, 1 back, and 0 being a meaningless default? Since the row chunk is not present in save data when defaulted, there doesn't seem anyway to know what the front value is in RPG_RT without looking at process memory, but I can't see why it would be -1.

@fmatthew5876 fmatthew5876 referenced this pull request Nov 24, 2018

Merged

Fix SaveActor::row #1507

Fix SaveActor::row
* 0 - front
* 1 - back

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:row branch from 940e0d3 to c4066da Nov 24, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Nov 26, 2018

No idea how I came up with -1, guess I changed it until it loaded correctly from a RPG_RT save ;)

@Ghabry

Ghabry approved these changes Nov 26, 2018

@carstene1ns
Copy link
Member

carstene1ns left a comment

LGTM

@carstene1ns carstene1ns merged commit b185957 into EasyRPG:master Nov 28, 2018

4 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:row branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.