Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for Skill::animation_id #284

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Nov 30, 2018

Causes skills with default (missing) animation_id chunk
to not play correctly in Player battle system.

@fmatthew5876 fmatthew5876 changed the title Fix default for animation.skill_id Fix default for skill.animation_id Nov 30, 2018

@fmatthew5876 fmatthew5876 changed the title Fix default for skill.animation_id Fix default for Skill::animation_id Nov 30, 2018

Fix default for Skill::animation_id
Causes skills with default (missing) animation_id chunk
to not play correctly in Player battle system.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:skill_anim branch from 2418d1d to f2aa414 Nov 30, 2018

@fdelapena fdelapena added the Chunks label Nov 30, 2018

@fdelapena fdelapena added this to the 0.6.0 (likely) milestone Nov 30, 2018

@Ghabry

Ghabry approved these changes Dec 1, 2018

@Ghabry Ghabry merged commit 67202d6 into EasyRPG:master Dec 1, 2018

4 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:skill_anim branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.