Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all liblcf structs comparable #291

Merged
merged 11 commits into from Dec 9, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Dec 2, 2018

  • Simplifies and streamlines comparison logic
  • Removes meta function hacks around comparison in reader_struct
  • Adds additional utility for users of liblcf
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 2, 2018

@Ghabry This one will require us to re-test copying for LDB, LMT, LMU, and LSD. I'll check on my side today but please if you could also run your test suite again to sanity check me.

fmatthew5876 added some commits Dec 2, 2018

@fdelapena fdelapena added this to the 0.6.0 (likely) milestone Dec 2, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 3, 2018

I've run this PR against my collection of games and they copy clean.

@carstene1ns carstene1ns requested a review from Ghabry Dec 6, 2018

@Ghabry

Ghabry approved these changes Dec 9, 2018

Copy link
Member

Ghabry left a comment

Also getting 100% here

@Ghabry Ghabry merged commit 068a8aa into EasyRPG:master Dec 9, 2018

5 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.