Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Maintenance #298

Merged
merged 9 commits into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@carstene1ns
Copy link
Member

carstene1ns commented Dec 14, 2018

No description provided.

@fdelapena fdelapena added the Building label Dec 16, 2018

@fdelapena fdelapena added this to the 0.6.0 (likely) milestone Dec 17, 2018

Show resolved Hide resolved CMakeLists.txt
source_group("Source Files\\${SG}" REGULAR_EXPRESSION "${LSG}_.*\\.cpp")
source_group("Header Files\\${SG}" REGULAR_EXPRESSION "${LSG}_.*\\.h")
endforeach()

# C++11 is required
target_compile_features(lcf PUBLIC cxx_std_11)

This comment has been minimized.

@Ghabry

Ghabry Dec 17, 2018

Member

while we are at maintanance could you change this to the CMake 3.7 compatible:

set_target_properties(lcf PROPERTIES
    CXX_STANDARD 11
    CXX_STANDARD_REQUIRED ON
    CXX_EXTENSIONS OFF
)

This comment has been minimized.

@carstene1ns

carstene1ns Dec 18, 2018

Author Member

I have instead used the older default value for this, as the tests would not get the required -std=c++11 parameter otherwise without specifying it again.
Not a problem on current compilers, as their default may be c++14 already.
https://cmake.org/cmake/help/v3.8/variable/CMAKE_CXX_STANDARD.html

@Ghabry

Ghabry approved these changes Dec 18, 2018

@Ghabry Ghabry merged commit bce2753 into EasyRPG:master Dec 18, 2018

5 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:cmakery branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.