Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCF mime types and install them #301

Merged
merged 2 commits into from Jan 20, 2019

Conversation

Projects
None yet
2 participants
@carstene1ns
Copy link
Member

carstene1ns commented Jan 1, 2019

No description provided.

@carstene1ns carstene1ns force-pushed the carstene1ns:mime branch from b950aba to dca6dcb Jan 2, 2019

@carstene1ns carstene1ns added this to the 0.6.0 (likely) milestone Jan 2, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Jan 2, 2019

Oh, you already force-pushed away the issue I noticed yesterday.

The other problem (or discussion topic) I see is: Is it intended to alter the system mime database when cross-compiling? Imo a cross-compile should not modify the host-system it is compiled on. In CMake this is detectable via CMAKE_CROSSCOMPILING (is broken on OSX but not relevant here).

No mime update when cross-compiling
Ignore all ninja generated files
@carstene1ns

This comment has been minimized.

Copy link
Member Author

carstene1ns commented Jan 4, 2019

Added a commit that fixes this.

@Ghabry

Ghabry approved these changes Jan 20, 2019

@Ghabry Ghabry merged commit d48e77e into EasyRPG:master Jan 20, 2019

5 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:mime branch Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.