Add Maniac patch chunks #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unk is always a bug.
|
maniac_event_info, maniac_event_page and maniac_event_id are kinda broken. Guess this was fixed later in a non-released version. |
fdelapena
approved these changes
Mar 17, 2021
fmatthew5876
approved these changes
Mar 22, 2021
|
Looks fine to me, but do we have all these marked as tasks in a Player issue? I don't want to add a bunch of chunks and then we forget we need to add support for them in Player. |
|
No but this sounds like a good idea, will open a new issue for this as the Maniac issue is already bloated enough ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
ForManiacEventInfofigure out what thewas*things areStill some unknown chunks, waiting for BingShan reponse