New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more hardcoded terms customizable #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all useful
jenkins: test this please |
@rueter37 I'm currently thinking about a system to attach "custom game data" to database objects so games can Get/Set this stuff via a new Event command. This is an enhancement over the ugly comment-parsing they do in RPG XP and newer. |
The following database settings have been added: - Skill option 201: RPG Maker 2003 skill start notification - Item option 201: Item usage message in battle - Term 218: RPG Maker 2003 general skill start notification - Term 219: RPG Maker 2003 general item start notification
@Ghabry I moved the RPG Maker 2003 skill start notification and the item usage message from chunk 200 to 201 now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the player pr has enough approvals I will merge the liblcf side
This pull requests add some EasyRPG-customizable terms. They will only work in EasyRPG, and will be overriden if someone attemps to edit the project in RPG Maker 2000/2003. Some allow to replace hardcoded things (like terms in the Status scene), while others allow to customise messages per item or per skill. * Introduced in [liblcf#419](EasyRPG/liblcf#419) * `@easyrpg_using_message` in `RPG::Item`: per-item custom message about using the item, * `@easyrpg_battle_message_2k3` in `RPG::Skill`: per-skill custom message about using the skill, * `easyrpgAnnBattleItem2k3` term: generic message before using a skill (allows %S, %O placeholders) * `easyrpgAnnBattleSkill2k3` term: generic message before using an item (allows %S, %O, %U placeholders) * Introduced in [liblcf#414](EasyRPG/liblcf#414): * ``easyrpgItemNumberSeparator`` term: Item number separator * ``easyrpgSkillCostSeparator`` term: Skill cost separator * ``easyrpgEquipmentArrow`` term: Equipment window arrow * ``easyrpgStatusSceneName`` term: Status scene Name * ``easyrpgStatusSceneClass`` term: Status scene Class * ``easyrpgStatusSceneTitle`` term: Status scene Title * ``easyrpgStatusSceneCondition`` term: Status scene Condition * ``easyrpgStatusSceneFront`` term: Status scene Front * ``easyrpgStatusSceneBack`` term: Status scene Back * ``easyrpgOrderSceneConfirm`` term: Order scene Confirm * ``easyrpgOrderSceneRedo`` term: Order scene Redo * ``easyrpgAnnBattleDoubleAttack2k3`` term: RPG Maker 2003 battle monster Double Attack notification * ``easyrpgAnnBattleDefend2k3`` term: RPG Maker 2003 battle monster Defend notification * ``easyrpgAnnBattleObserve2k3`` term: RPG Maker 2003 battle monster Observe notification * ``easyrpgAnnBattleCharge2k3`` term: RPG Maker 2003 battle monster Charge notification * ``easyrpgAnnBattleSelfdestruct2k3`` term: RPG Maker 2003 battle monster Self-Destruct notification * ``easyrpgAnnBattleEscape2k3`` term: RPG Maker 2003 battle monster Escape notification * ``easyrpgAnnBattleSpecialCombatBack2k3`` term: Message for back and pincer attack
This pull requests add some EasyRPG-customizable terms. To allow making optional terms, Terms is rewritten from an array into a normal object. The newly-added terms will only work in EasyRPG, and will be overriden if someone attemps to edit the project in RPG Maker 2000/2003. Some allow to replace hardcoded things (like terms in the Status scene), while others allow to customise messages per item or per skill. * Introduced in [liblcf#419](EasyRPG/liblcf#419) * `@easyrpg_using_message` in `RPG::Item`: per-item custom message about using the item, * `@easyrpg_battle_message_2k3` in `RPG::Skill`: per-skill custom message about using the skill, * `easyrpgAnnBattleItem2k3` term: generic message before using a skill (allows %S, %O placeholders) * `easyrpgAnnBattleSkill2k3` term: generic message before using an item (allows %S, %O, %U placeholders) * Introduced in [liblcf#414](EasyRPG/liblcf#414): * ``easyrpgItemNumberSeparator`` term: Item number separator * ``easyrpgSkillCostSeparator`` term: Skill cost separator * ``easyrpgEquipmentArrow`` term: Equipment window arrow * ``easyrpgStatusSceneName`` term: Status scene Name * ``easyrpgStatusSceneClass`` term: Status scene Class * ``easyrpgStatusSceneTitle`` term: Status scene Title * ``easyrpgStatusSceneCondition`` term: Status scene Condition * ``easyrpgStatusSceneFront`` term: Status scene Front * ``easyrpgStatusSceneBack`` term: Status scene Back * ``easyrpgOrderSceneConfirm`` term: Order scene Confirm * ``easyrpgOrderSceneRedo`` term: Order scene Redo * ``easyrpgAnnBattleDoubleAttack2k3`` term: RPG Maker 2003 battle monster Double Attack notification * ``easyrpgAnnBattleDefend2k3`` term: RPG Maker 2003 battle monster Defend notification * ``easyrpgAnnBattleObserve2k3`` term: RPG Maker 2003 battle monster Observe notification * ``easyrpgAnnBattleCharge2k3`` term: RPG Maker 2003 battle monster Charge notification * ``easyrpgAnnBattleSelfdestruct2k3`` term: RPG Maker 2003 battle monster Self-Destruct notification * ``easyrpgAnnBattleEscape2k3`` term: RPG Maker 2003 battle monster Escape notification * ``easyrpgAnnBattleSpecialCombatBack2k3`` term: Message for back and pincer attack
This pull requests add some EasyRPG-customizable terms. To allow making optional terms, Terms is rewritten from an array into a normal object. The newly-added terms will only work in EasyRPG, and will be overriden if someone attemps to edit the project in RPG Maker 2000/2003. Some allow to replace hardcoded things (like terms in the Status scene), while others allow to customise messages per item or per skill. * Introduced in [liblcf#419](EasyRPG/liblcf#419) * `@easyrpg_using_message` in `RPG::Item`: per-item custom message about using the item, * `@easyrpg_battle_message_2k3` in `RPG::Skill`: per-skill custom message about using the skill, * `easyrpgAnnBattleItem2k3` term: generic message before using a skill (allows %S, %O placeholders) * `easyrpgAnnBattleSkill2k3` term: generic message before using an item (allows %S, %O, %U placeholders) * Introduced in [liblcf#414](EasyRPG/liblcf#414): * ``easyrpgItemNumberSeparator`` term: Item number separator * ``easyrpgSkillCostSeparator`` term: Skill cost separator * ``easyrpgEquipmentArrow`` term: Equipment window arrow * ``easyrpgStatusSceneName`` term: Status scene Name * ``easyrpgStatusSceneClass`` term: Status scene Class * ``easyrpgStatusSceneTitle`` term: Status scene Title * ``easyrpgStatusSceneCondition`` term: Status scene Condition * ``easyrpgStatusSceneFront`` term: Status scene Front * ``easyrpgStatusSceneBack`` term: Status scene Back * ``easyrpgOrderSceneConfirm`` term: Order scene Confirm * ``easyrpgOrderSceneRedo`` term: Order scene Redo * ``easyrpgAnnBattleDoubleAttack2k3`` term: RPG Maker 2003 battle monster Double Attack notification * ``easyrpgAnnBattleDefend2k3`` term: RPG Maker 2003 battle monster Defend notification * ``easyrpgAnnBattleObserve2k3`` term: RPG Maker 2003 battle monster Observe notification * ``easyrpgAnnBattleCharge2k3`` term: RPG Maker 2003 battle monster Charge notification * ``easyrpgAnnBattleSelfdestruct2k3`` term: RPG Maker 2003 battle monster Self-Destruct notification * ``easyrpgAnnBattleEscape2k3`` term: RPG Maker 2003 battle monster Escape notification * ``easyrpgAnnBattleSpecialCombatBack2k3`` term: Message for back and pincer attack
Requirement for Player#2502
This PR adds the following database settings: