Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SavePicture: Add chunks for Flip and Blend Mode #434

Merged
merged 1 commit into from Sep 8, 2021

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Sep 1, 2021

Contrary to KeyInput where the usage of the upper bits made sense here it is far too ugly to handle this way:

Maniac Patch uses the upper bits of finish_bot_trans for this which is imo very very ugly.

Instead I add here 3 new chunks, so savegames will be incompatible.

The Blend Mode is an integer to get more flexibility compared to Multiply/Add/Overlay of Maniacs.

@Ghabry Ghabry marked this pull request as ready for review September 1, 2021 15:13
@Ghabry Ghabry added this to the 0.7.0 milestone Sep 1, 2021
@carstene1ns
Copy link
Member

IMO the flip mode should be an enum: FlipNone, FlipX, FlipY, FlipBoth, it would need only one chunk this way.
However, two chunks is also okay.

Flip & Blend: Maniac Patch uses the upper bits of finish_bot_trans for this which is ugly
Fixed Angle: This is a new value for the effect parameter. Had to put this in the normal enums.csv due to generator limitations
@Ghabry
Copy link
Member Author

Ghabry commented Sep 6, 2021

reduced to one Flip chunk and added a new enum for the "effect": This is for the fixed angle (instead of rotating)

@fdelapena fdelapena merged commit 3f5cbdc into EasyRPG:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants