Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake config: 3rd try #451

Merged
merged 1 commit into from
Jan 23, 2023
Merged

CMake config: 3rd try #451

merged 1 commit into from
Jan 23, 2023

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Jan 22, 2023

Tested now the following combinations:

  • liblcf build with autotools
  • liblcf build with CMake

For both static and shared.

Then compiled Player:

  • CMake with liblcf autotools: Both "pkg-config" and "pkg-config --static" tested (4 builds)
  • CMake with liblcf CMake (2 builds)

Everything works. This stuff is so dumb.

@Ghabry
CMake-config Fixes
64c37de 
autotools: CMake config handles now linking against the static library correctly
CMake: CMake config populates now the include directly correctly
@Ghabry Ghabry added this to the 0.7.1 milestone Jan 22, 2023
@fdelapena fdelapena requested a review from carstene1ns January 22, 2023 16:27
carstene1ns
carstene1ns approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carstene1ns carstene1ns merged commit 8b1d644 into EasyRPG:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carstene1ns carstene1ns carstene1ns approved these changes

@fdelapena fdelapena fdelapena approved these changes

Assignees
No one assigned
Labels
Building
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ghabry @fdelapena @carstene1ns