Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vector<DBString> #455

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Support Vector<DBString> #455

merged 2 commits into from
Apr 24, 2023

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Apr 24, 2023

Maniac Patch uses this. Thanks to Jorge Pixel for figuring out how the array is structured.

Citing from the sourcecode

Vector<DBString> is Maniac Patch and is sparse:
When size is > 0xFFFFFFFF there is a gap of "0x800000000 - size"
In other cases it is as above: Size Data ... Size Data

Note that this is only implemented for Vector<DBString>, not Vector<std::string>. During runtime the vector is not sprase, so every slot consumes memory. As most of the vector is empty our DBString is much more memory friendly.



lcf2xml for testing

@Ghabry Ghabry added this to the 0.8.0 milestone Apr 24, 2023
@fdelapena fdelapena merged commit d1fc1b4 into EasyRPG:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants