Remove Iconv support - #471
Merged
2 commits merged intoDec 1, 2023
Merged
Conversation
We do not use this anywhere since years. Is a maintenance burden and nobody tests this. Fix EasyRPG#465
Mostly for testing purposes.
ghost
approved these changes
Nov 29, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes iconv (which is untested since years) making ICU the only supported implementation.
As a bonus ICU can be still disabled. In this case only windows-1252 is supported (this means English games and Western European games will work even without ICU).
Useful for testing, useless for fans of
walkingdreaming simulators. ;)