Change default CE to have the "call" trigger type#484
Merged
Conversation
ghost
approved these changes
Oct 9, 2024
ghost
requested a review
from 
Ghabry
approved these changes
Oct 9, 2024
Ghabry
left a comment
Ghabry
left a comment
Member
There was a problem hiding this comment.
right, this also matches with the value in the enum.
Went unnoticed, because:
- Player code only checks for autorun and parallel
- Default values are not written into the lcf files, so the wrong value never appears inside the files (so not even testing in RPG_RT.exe could catch this)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CEs initializing with an invalid trigger type value of 0 by properly replacing it with 5 ("call" type).