Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New References on free-courses-id.md #3779

Closed
VicoSilalahi opened this issue Oct 5, 2020 · 4 comments
Closed

New References on free-courses-id.md #3779

VicoSilalahi opened this issue Oct 5, 2020 · 4 comments

Comments

@VicoSilalahi
Copy link
Contributor

@VicoSilalahi VicoSilalahi commented Oct 5, 2020

C++

I've tried doing PR but didn't know what to do after getting build fail, don't know what's Travis ci means.

@Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Oct 6, 2020

Hi @VicoSilalahi

The issues with your PR are:

  • Incorrect number of blank lines between last section and next heading
  • Incorrect number of blank lines between heading and section

in the free-courses-id.md file

Please read the Formatting section of CONTRIBUTING.md file and fix your changes accordingly.

I hope this helps you resolve the issues. Good luck!

@VicoSilalahi
Copy link
Contributor Author

@VicoSilalahi VicoSilalahi commented Oct 6, 2020

Hi @Tahanima , thanks for your response, in my new PR, the build was successful, it was a new fork from the latest commit, i added the resources above as well as some more.

@eshellman
Copy link
Collaborator

@eshellman eshellman commented Oct 6, 2020

Thanks for the help, @Tahanima

@Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Oct 6, 2020

You're welcome @VicoSilalahi and @eshellman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants