New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable client key passphrase for JWT token authentication request #50

Merged
merged 2 commits into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@rjprins
Copy link
Member

rjprins commented Mar 28, 2018

  • Also add code coverage for SSL requests

This change is Reviewable

Enable client key passphrase for JWT token authentication request
* Also add code coverage for SSL requests

@rjprins rjprins requested a review from traut Mar 28, 2018

@traut

traut approved these changes Mar 28, 2018


# session 'verify' attribute can be a bool or a path to a CA bundle:
if not isinstance(session.verify, bool):
ca_cert = session.verify
context = ssl.create_default_context(
ssl.Purpose.CLIENT_AUTH, cafile=ca_cert)

This comment has been minimized.

@rjprins

rjprins Mar 28, 2018

Member

ca_cert might not be defined if session.verify is False

Add additional tests for SSL authentication and fix minor bug
ca_cert variable in request_with_key_password might be undefined
before use.

@rjprins rjprins merged commit fb0f73b into master Mar 29, 2018

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
code-review/reviewable 10 files, 1 discussion left
Details
continuous-integration/codeship Build succeeded
Details

@rjprins rjprins deleted the fix-client-key-passphrase-for-jwt-auth branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment