add custom search + embed planeteclipse.org posts #193
Conversation
|
✔️ Deploy Preview for eclipsefdn-ecdtools ready! 🔨 Explore the source changes: f236037 🔍 Inspect the deploy log: https://app.netlify.com/sites/eclipsefdn-ecdtools/deploys/61b0e86d6178e500083c3bc6 😎 Browse the preview: https://deploy-preview-193--eclipsefdn-ecdtools.netlify.app |
chrisguindon
force-pushed
the
cguindon/master/updates
branch
from
2eac450 to
b64a936
Compare
Signed-off-by: Christopher Guindon <chris.guindon@eclipse-foundation.org>
chrisguindon
force-pushed
the
cguindon/master/updates
branch
from
b64a936 to
af0a31b
Compare
js/src/EclipseBlogs.js
Outdated
| date: '', | ||
| id: '', | ||
| author: '', | ||
| formatDate: function () { |
There was a problem hiding this comment.
Why do you have 2 nested functions here?
There was a problem hiding this comment.
See lambda section https://mustache.github.io/mustache.5.html
ericpoirier
left a comment
ericpoirier
left a comment
There was a problem hiding this comment.
Looks good but your PR has conflicts
| --- | ||
|
|
||
| {{< page/join-us >}} | ||
| {{< hubspot_contact_form portalId="5413615" formId="b2d1d804-1d76-4fe9-9647-03f478af1780" >}} |
There was a problem hiding this comment.
I'm assuming you're adding this here since you're making changes to ECDtools?
There was a problem hiding this comment.
We should be using our shortcode for this.
There was a problem hiding this comment.
I don't see any conflicts?
2 participants
Fix #160
Fix #157
Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org