Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

initial trial to custom header for sub-sites #196

Merged

Conversation

flora8984461
Copy link
Contributor

@flora8984461 flora8984461 commented Jan 11, 2021

Fix #88

One example can be https://deploy-preview-196--eclipsefdn-hugo-solstice-theme.netlify.app/subsite-1/
You can assume it is a subsite with its independent logo and logo url.

Another example can be https://deploy-preview-196--eclipsefdn-hugo-solstice-theme.netlify.app/third-parent/
You can assume it's another subsite with another independent logo and logo url.

Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org

@netlify
Copy link

netlify bot commented Jan 11, 2021

Deploy preview for eclipsefdn-hugo-solstice-theme failed.

Built with commit 68cf624

https://app.netlify.com/sites/eclipsefdn-hugo-solstice-theme/deploys/60524691bfe51000074a03da

@flora8984461 flora8984461 marked this pull request as ready for review Jan 13, 2021
.gitignore Show resolved Hide resolved
@@ -0,0 +1,11 @@
items:
-
page_url: '/subsite-1'
Copy link
Member

@chrisguindon chrisguindon Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flora8984461 to confirm, this new logo will be used on sub pages of that section right?

Copy link
Contributor Author

@flora8984461 flora8984461 Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, subsite-1, and its children, subsite-1/*/* ...

@flora8984461 flora8984461 force-pushed the yiliu/master/customHeader branch from 5e7262d to 514ade5 Compare Jan 19, 2021
@flora8984461 flora8984461 requested a review from chrisguindon Jan 19, 2021
@flora8984461 flora8984461 requested a review from autumnfound Jan 20, 2021
<img width="{{ $.Page.Params.logo_width | default $.Site.Params.logo_width | default "140"}}" class="logo-eclipse-default-mobile img-responsive" src="{{ . | absURL }}" alt="{{ $.Site.Title }}" />
{{ $currentPageLogo := . }}
{{ $currentPageLogoTitle := $.Site.Title }}
{{ $currentPageLogoLink := "" | absLangURL }}
Copy link
Contributor

@autumnfound autumnfound Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't double URL convert this (you call absLangURL later on as well). Might do something unexpected, remove it here and just leave it in the later line

@flora8984461 flora8984461 requested a review from autumnfound Feb 22, 2021
Copy link
Member

@chrisguindon chrisguindon left a comment

I think it would be best to move these "fake" images in the examplesite/static folder. We don't need them on all our sites.

Yi Liu added 7 commits Mar 8, 2021
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@flora8984461 flora8984461 force-pushed the yiliu/master/customHeader branch from 5c85960 to c700900 Compare Mar 8, 2021
@flora8984461 flora8984461 requested a review from chrisguindon Mar 8, 2021
@flora8984461
Copy link
Contributor Author

flora8984461 commented Mar 8, 2021

I think it would be best to move these "fake" images in the examplesite/static folder. We don't need them on all our sites.

Updated.

@chrisguindon chrisguindon merged commit 577a7d2 into EclipseFdn:master Mar 22, 2021
2 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ability to customize header per section
3 participants