Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Contribution for Turkish website #221

Merged
merged 11 commits into from Apr 27, 2021
Merged

Conversation

hakdogan
Copy link
Contributor

@hakdogan hakdogan commented Apr 16, 2021

This pull request was made to contribute to the website prepared for JakartaOne Livestream Turkish. Details: jakartaee/jakartaone.org#279

@netlify
Copy link

netlify bot commented Apr 16, 2021

Deploy preview for eclipsefdn-hugo-solstice-theme ready!

Built with commit 5d9adb4

https://deploy-preview-221--eclipsefdn-hugo-solstice-theme.netlify.app

@autumnfound
Copy link
Contributor

autumnfound commented Apr 19, 2021

Looking at the details of your ECA status (the details of the ECA check) it looks like the email that is associated with your computer's Git does not have a signed ECA. Can you confirm this? Thanks!

EDIT: Otherwise, your PR passes, its just the legal stuff for coverage. Forgot to mention that, whoops!

@hakdogan
Copy link
Contributor Author

hakdogan commented Apr 19, 2021

Looking at the details of your ECA status (the details of the ECA check) it looks like the email that is associated with your computer's Git does not have a signed ECA. Can you confirm this? Thanks!

EDIT: Otherwise, your PR passes, its just the legal stuff for coverage. Forgot to mention that, whoops!

I have signed ECA with my email associated with the GIT. I see that email when use git config --list in my local but when I visit the detail page of failed commit by clicking cross mark, I see my public e-mail as anonymous on the eclipse ECA validation page. I guess I need to change the email on my profile with the email where I signed the ECA. What do you think?

@autumnfound
Copy link
Contributor

autumnfound commented Apr 19, 2021

It seems to be able to see your new ECA for the validation (you need to click the "Revalidate" button to check if you clear the ECA since there is some Github workflows we need to trigger). There seems to be 2 emails associated now though. I'm guessing that you updated your Git email address as well as signing the ECA?

@hakdogan
Copy link
Contributor Author

hakdogan commented Apr 19, 2021

I'm guessing that you updated your Git email address as well as signing the ECA?

Yeah. I made the email where I signed the ECA as my public GIT email.

@hakdogan
Copy link
Contributor Author

hakdogan commented Apr 20, 2021

Hi @autumnfound,

To resolve ECA validation problem, I changed the author email by rebase command but looks like it didn't work. Do you have any other suggestions?

@autumnfound
Copy link
Contributor

autumnfound commented Apr 22, 2021

It looks like the easiest way would be for us to squash merge when we finish the PR. This would fix the complaints, and we already know you've signed! Sometimes we hand wave it locally once we know its good to go in the future.

Let me know when you're good to merge and we can do so!

@autumnfound
Copy link
Contributor

autumnfound commented Apr 26, 2021

Gentle ping, since we want to merge this in today or tomorrow latest!

@autumnfound autumnfound reopened this Apr 26, 2021
@autumnfound
Copy link
Contributor

autumnfound commented Apr 26, 2021

Sorry misclick!

@hakdogan
Copy link
Contributor Author

hakdogan commented Apr 27, 2021

Hi @autumnfound,

Let me know when you're good to merge and we can do so!

If not now when :)

@autumnfound autumnfound merged commit 329c563 into EclipseFdn:master Apr 27, 2021
6 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants