Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

add flexibility to footer #230

Merged

Conversation

chrisguindon
Copy link
Member

@chrisguindon chrisguindon commented Jun 7, 2021

Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org

Signed-off-by: Christopher Guindon <chris.guindon@eclipse-foundation.org>
@netlify
Copy link

netlify bot commented Jun 7, 2021

✔️ Deploy Preview for eclipsefdn-hugo-solstice-theme ready!

🔨 Explore the source changes: 53742aa

🔍 Inspect the deploy log: https://app.netlify.com/sites/eclipsefdn-hugo-solstice-theme/deploys/60be6a2176986a0007b3139d

😎 Browse the preview: https://deploy-preview-230--eclipsefdn-hugo-solstice-theme.netlify.app

Signed-off-by: Christopher Guindon <chris.guindon@eclipse-foundation.org>
Copy link
Contributor

@autumnfound autumnfound left a comment

The code looks great! Was the change in naming convention for the link partials an intentional choice?

@chrisguindon
Copy link
Member Author

chrisguindon commented Jun 7, 2021

@autumnfound Yes, we are not consistent so I had to pick:
https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/partials/sidebar-block.html
https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/partials/collapsible-menu.html

I decided to use the id name for each section. However, since most of them are using _ in the root of the partial folder, I went with footer_links and footer_js.

There is always logic to my madness but I don't have a strong opinion. I can change it to use _ if you feel strongly about it.

@chrisguindon chrisguindon merged commit 37bc486 into EclipseFdn:master Jun 7, 2021
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants