This repository was archived by the owner on Mar 26, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 21
Improve the sidebar menu #350 #539
Merged
chrisguindon
merged 14 commits into
EclipseFdn:master
from
flora8984461:yiliu/master/improveSidebar
Mar 22, 2021
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3a72094
initial trial
3e4faca
update the sidebar and mobile-sidebar
4a301e2
style the dropdown
6559b7d
Add param in mobile-sidebar and bring back the default sidebar on mob…
779cbf0
organize format
3d681ae
updates according to comments
9b9251d
remove dropdown
4256c32
remove sidebar mobile dropdown style
b866a50
adjustment
356b4ca
update theme
ced775e
More updates to better user exp
6f2a6d8
Updates based on Eric's new sidebar-block
c01006c
Update hugo theme
82c6a69
Update styles
ericpoirier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the changes here,
I was confused by the previous logic that we need to create middle-layer sidebar menus twice in order to show on the page so that I made some modifications to just create once. Please also refer to the changes I made in "layouts/partials/sidebar.html".
This gives me a better understanding to create the mobile-sidebar.