Skip to content
This repository has been archived by the owner. It is now read-only.

PHP 7.2 compatibility #166

Closed
wants to merge 1 commit into from

Conversation

@cyMarvin
Copy link

commented Aug 14, 2018

Using openssl for PHP versions 7.2 and higher since mcrypt was removed for those.

PHP 7.2 compatibility
Using openssl for PHP versions 7.2 and higher since mcrypt was removed or those.
@PowerKiKi

This comment has been minimized.

Copy link
Member

commented Aug 16, 2018

Thanks for the contribution, it seems to be a good start.

But I think we need to go all the way and drop mcrypt entirely. Using one or the other conditionally make it dangerous when run via a web server, or run via CLI. I've seen first hand that it is too easy to mess up server configuration and end up running CLI with a different PHP version than the web. This would lead to hard to debug issues.

Also we should either figure out a way to migrate existing data, or declare this change as breaking and instruct users to re-configure their passwords.

Finally unit tests may have to be adapted. At first you can easily fix the code style issues with ./vendor/bin/php-cs-fixer fix.

@PowerKiKi PowerKiKi added this to the 4.0 milestone Jan 8, 2019

@PowerKiKi PowerKiKi closed this in b4eea50 Feb 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.