Skip to content

Conversation

@MatthewCMoya
Copy link
Contributor

@MatthewCMoya MatthewCMoya commented Sep 9, 2019

Description

  • This pr changes the offset logic in the scroll monitor to allow users to pass positive values for offset in compliance with industry standard

PR Requirements

Before requesting review this criteria must be met:
Overall test coverage >= current master?

  • Yes
  • N.A.

Documentation included (if any behavioral changes)?

  • Yes
  • N.A.

Backwards compatibility (if breaking change)?

  • Yes
  • N.A.

Release

Will this pr trigger a release i.e. version in package.json has been bumped?

  • Yes
  • No

Screenshots

If U.I. component, include screenshots or video screen capture showing
behavior and responsive styling below.

@MatthewCMoya MatthewCMoya merged commit 66f468f into master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants