From 3de9dd9014c7950fa0bb45642761106075cec6e5 Mon Sep 17 00:00:00 2001 From: Filipp Semenkov Date: Tue, 27 Feb 2024 23:49:10 +0400 Subject: [PATCH 1/2] ECWID-134030 New Reports: internal API for addToCartConversion report: add productInfo: - added AdditionalProductData --- src/main/kotlin/com/ecwid/apiclient/v3/ApiClientHelper.kt | 3 ++- .../v3/dto/report/result/FetchedReportResponse.kt | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/main/kotlin/com/ecwid/apiclient/v3/ApiClientHelper.kt b/src/main/kotlin/com/ecwid/apiclient/v3/ApiClientHelper.kt index d435e2cbd..189029d67 100644 --- a/src/main/kotlin/com/ecwid/apiclient/v3/ApiClientHelper.kt +++ b/src/main/kotlin/com/ecwid/apiclient/v3/ApiClientHelper.kt @@ -530,7 +530,8 @@ private fun createAdditionalDataPolymorphicType(): PolymorphicType Date: Wed, 28 Feb 2024 01:22:02 +0400 Subject: [PATCH 2/2] ECWID-134030 New Reports: internal API for addToCartConversion report: add productInfo: - Allow nullable values for properties in AdditionalProductData --- .../com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt b/src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt index f69d24fa4..2e492ab2c 100644 --- a/src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt +++ b/src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt @@ -110,6 +110,11 @@ val otherNullablePropertyRules: List> = listOf( AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalInventoryData::thumbnailUrl), AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalInventoryData::exampleOrder), + AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productName), + AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productSmallThumbnailUrl), + AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productUrl), + AllowNullable(FetchedReportResponse.FetchedAdditionalData.AdditionalProductData::productEditUrl), + AllowNullable(CreateBatchRequest::groupId), AllowNullable(CreateBatchRequestWithIds::groupId),