Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: elaborating on step 8 in open source map #9353

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 4, 2023

Fixes Issue

Closes #9152

Changes proposed

This pull request adds information to Step 8 of the open source roadmap. It focuses on ways contributors can become maintainers, helping them gain a better understanding of how to make this transition.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

N/A

@CBID2 CBID2 requested a review from SaraJaoude as a code owner October 4, 2023 19:09
@github-actions github-actions bot added 📖 docs Documentation pages issue linked Pull Request has issue linked labels Oct 4, 2023
Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please look at the Issue again - we discussed that you would be amending the short description of Step 8 on the Open Source Main Content Page by deleting the words reviewing other people's changes as shown in the crossed off section below:

Screenshot 1:
272523459-90da6fc4-c471-4c11-babd-466c26c64a72

However, it seems that you have added the content of what you intended to write for the Step 8 page (please also see my separate comment on this below):

Screenshot 2023-10-04 at 20 52 56

Also, as reflected in the Issue you were going to change the words (coming soon) as shown circled in Screenshot 1 above, to (draft).

However it seems that you have added the word draft to the Step 8 page (where the content you were going to write should go).

Screenshot 2023-10-04 at 20 53 05

@CBID2 CBID2 marked this pull request as draft October 4, 2023 20:23
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 4, 2023

Hi @SaraJaoude. I implemented your suggestions a bit. This time, I used a scaffolding-like approach to describe the tips (scaffolding is teaching jargon for building one topic on another. In this case, it would be maintaining other projects, more specifically, ones they have contributed to in the past, and then taking that experience and applying it to their own project.) because I picture the person reading that step as someone who followed the previous steps consistently and is now at the stage where they are ready to become a maintainer but not ready enough to do their own projects. Does that make sense?

@CBID2 CBID2 marked this pull request as ready for review October 15, 2023 05:24
@CBID2 CBID2 requested a review from SaraJaoude October 15, 2023 23:46
@SaraJaoude SaraJaoude dismissed their stale review October 17, 2023 20:59

I have now made the required changes

@SaraJaoude
Copy link
Member

I have addressed the outstanding issues.

I can see that changing the "Coming Soon" section which should have been changed to "Draft" mentioned in the Issue has not been addressed. This can be dealt with in another PR.

@SaraJaoude SaraJaoude merged commit c859881 into EddieHubCommunity:main Oct 17, 2023
7 of 9 checks passed
@CBID2 CBID2 deleted the elaborating-on-step-8-in-open-source-roadmap branch October 17, 2023 22:15
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 17, 2023

I have addressed the outstanding issues.

I can see that changing the "Coming Soon" section which should have been changed to "Draft" mentioned in the Issue has not been addressed. This can be dealt with in another PR.

Ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 docs Documentation pages issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS]: Adding content to Step 8 in Open Source Roadmap
3 participants